Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tests/html/html.status

Issue 1679603002: cpsir: triage remainder of html test suite, fix a couple. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« sdk/lib/html/dart2js/html_dart2js.dart ('K') | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | tests/html/input_element_test.dart » ('j') | tests/html/input_element_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/html/html.status
diff --git a/tests/html/html.status b/tests/html/html.status
index c0f0a2bffba4c048d3703c201fc68a60ad705e04..fbb4bacd49ceb93ce2daa67ff1000d5e8cc7d714 100644
--- a/tests/html/html.status
+++ b/tests/html/html.status
@@ -423,31 +423,33 @@ window_nosuchmethod_test: StaticWarning
resource_http_test: Crash # (await for(var b in r.openRead()){bytes.addAll(b);}): await for
[ $compiler == dart2js && $cps_ir && $browser ]
-custom/element_upgrade_test: RuntimeError # Please triage
-js_dart_to_string_test: RuntimeError # Please triage
-custom_elements_23127_test/c2t: RuntimeError # Please triage
-custom_elements_23127_test/c2: RuntimeError # Please triage
-custom_elements_23127_test/baseline: RuntimeError # Please triage
-keyboard_event_test: RuntimeError # Please triage
Siggi Cherem (dart-lang) 2016/02/06 02:36:27 Sorry for the noise from sorting. I'll highlight t
-js_typed_interop_test: RuntimeError # Please triage
-js_typed_interop_side_cast_test: RuntimeError # Please triage
-js_typed_interop_anonymous_exp_test: RuntimeError # Please triage
-custom_elements_test/register: RuntimeError # Please triage
-js_typed_interop_anonymous2_test: RuntimeError # Please triage
-js_typed_interop_anonymous_test: RuntimeError # Please triage
-js_array_test: RuntimeError # Please triage
-js_function_getter_test/call: RuntimeError # Please triage
-custom/mirrors_test: RuntimeError # Please triage
-custom/constructor_calls_created_synchronously_test: RuntimeError # Please triage
-input_element_test/attributes: Pass # Please triage
Siggi Cherem (dart-lang) 2016/02/06 02:36:27 I changed the tests slightly to make this one fail
-js_function_getter_trust_types_test: RuntimeError # Please triage
-js_typed_interop_side_cast_exp_test: RuntimeError # Please triage
-js_typed_interop_anonymous2_exp_test: RuntimeError # Please triage
-mirrors_js_typed_interop_test: RuntimeError # Please triage
-js_function_getter_test: RuntimeError # Please triage
-custom_elements_23127_test/c1t: RuntimeError # Please triage
-custom_elements_test/innerHtml: RuntimeError # Please triage
-mouse_event_test: RuntimeError # Please triage
Siggi Cherem (dart-lang) 2016/02/06 02:36:27 gone (fixed)
-js_test/JsObject_methods: RuntimeError # Please triage
-js_test/Dart_functions: RuntimeError # Please triage
-js_test/new_JsObject: RuntimeError # Please triage
+# Custom element support:
+custom/constructor_calls_created_synchronously_test: RuntimeError # Need custom element support #25484
+custom/element_upgrade_test: RuntimeError # Need custom element support #25484
+custom/mirrors_test: RuntimeError # Need custom element support #25484
+custom_elements_23127_test/baseline: RuntimeError # Need custom element support #25484
+custom_elements_23127_test/c2: RuntimeError # Need custom element support #25484
+custom_elements_23127_test/c1t: RuntimeError # Need custom element support #25484
+custom_elements_23127_test/c2t: RuntimeError # Need custom element support #25484
+custom_elements_test/innerHtml: RuntimeError # Need custom element support #25484
+custom_elements_test/register: RuntimeError # Need custom element support #25484
+
+# New js-interop support via package:js is only implemented in SSA:
+js_array_test: RuntimeError # Need package:js support #24978
+js_dart_to_string_test: RuntimeError # Need package:js support #24978
+js_function_getter_test/call: RuntimeError # Need package:js support #24978
+js_function_getter_test: RuntimeError # Need package:js support #24978
+js_function_getter_trust_types_test: RuntimeError # Need package:js support #24978
+js_typed_interop_anonymous2_exp_test: RuntimeError # Need package:js support #24978
+js_typed_interop_anonymous2_test: RuntimeError # Need package:js support #24978
+js_typed_interop_anonymous_exp_test: RuntimeError # Need package:js support #24978
+js_typed_interop_anonymous_test: RuntimeError # Need package:js support #24978
+js_typed_interop_side_cast_exp_test: RuntimeError # Need package:js support #24978
+js_typed_interop_side_cast_test: RuntimeError # Need package:js support #24978
+js_typed_interop_test: RuntimeError # Need package:js support #24978
+mirrors_js_typed_interop_test: RuntimeError # Need package:js support #24978
+
+# These are raw dart:js tests that fail due to invalid code for `new #()`:
+js_test/JsObject_methods: RuntimeError # Bad code for new #(). Issue #25708
+js_test/new_JsObject: RuntimeError # Bad code for new #(). Issue #25708
+js_test/Dart_functions: RuntimeError # Bad code for new #(). Issue #25708, also we seem to tree-shake a closure that escapes to js-interop
Siggi Cherem (dart-lang) 2016/02/06 02:40:06 looking closer into this one, I believe that only
« sdk/lib/html/dart2js/html_dart2js.dart ('K') | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | tests/html/input_element_test.dart » ('j') | tests/html/input_element_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698