Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 1678553002: Revert of Enable handle verifier for tests and add some tests. (Closed)

Created:
4 years, 10 months ago by Will Harris
Modified:
4 years, 10 months ago
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable handle verifier for tests and add some tests. (patchset #11 id:220001 of https://codereview.chromium.org/1580873003/ ) Reason for revert: This breaks on win7 component builds, and also win10. Original issue's description: > Enable handle verifier for tests and add some tests. > > Disable handle verifier hooks if running under drmemory. > > BUG=571304 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_chromium_dbg_ng > > Committed: https://crrev.com/5556e56290c41891b0830af9b6b9153b745dd226 > Cr-Commit-Position: refs/heads/master@{#372877} TBR=cpu@chromium.org,scottmg@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=571304, 583676, 584741 Committed: https://crrev.com/3d5ae6880f89c31701feda4e367ad0b0cad6e0a7 Cr-Commit-Position: refs/heads/master@{#373983}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -132 lines) Patch
M base/BUILD.gn View 3 chunks +0 lines, -15 lines 0 comments Download
M base/base.gyp View 2 chunks +0 lines, -8 lines 0 comments Download
M base/debug/close_handle_hook_win.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M base/test/test_suite.cc View 2 chunks +1 line, -6 lines 0 comments Download
M base/win/scoped_handle.h View 2 chunks +0 lines, -3 lines 0 comments Download
M base/win/scoped_handle.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M base/win/scoped_handle_unittest.cc View 2 chunks +0 lines, -79 lines 0 comments Download
M build/common.gypi View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Will Harris
Created Revert of Enable handle verifier for tests and add some tests.
4 years, 10 months ago (2016-02-05 23:34:05 UTC) #1
scottmg
On 2016/02/05 23:34:05, Will Harris wrote: > Created Revert of Enable handle verifier for tests ...
4 years, 10 months ago (2016-02-05 23:34:56 UTC) #3
Will Harris
I will eventually get these passing. ಠ_ಠ at rvargas for landing handle verifier without tests ...
4 years, 10 months ago (2016-02-05 23:36:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678553002/1
4 years, 10 months ago (2016-02-05 23:37:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678553002/1
4 years, 10 months ago (2016-02-06 00:04:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678553002/1
4 years, 10 months ago (2016-02-06 00:34:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678553002/1
4 years, 10 months ago (2016-02-06 01:03:24 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-06 01:29:19 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-06 01:30:51 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d5ae6880f89c31701feda4e367ad0b0cad6e0a7
Cr-Commit-Position: refs/heads/master@{#373983}

Powered by Google App Engine
This is Rietveld 408576698