build/common.gypi - Issue 1678553002: Revert of Enable handle verifier for tests and add some tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 1678553002: Revert of Enable handle verifier for tests and add some tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index c90f2657d512ca71a11f8280c508487db6f71271..40bb44ed5ce810f947856024d47bacd62b68d2d6 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -1588,10 +1588,6 @@

'libjpeg_ijg_gyp_path': '<(DEPTH)/third_party/libjpeg/libjpeg.gyp',

'libjpeg_turbo_gyp_path': '<(DEPTH)/third_party/libjpeg_turbo/libjpeg.gyp',

- # Whether to disable handle verifier hooks.

- # Hookless parts of the handle verifier will still function.

- 'win_disable_handle_verifier_hooks%': '0',

'conditions': [

['buildtype=="Official"', {

# Continue to embed build meta data in Official builds, basically the

@@ -2317,8 +2313,6 @@

# TODO(rnk): Combine with tsan config to share the builder.

# http://crbug.com/108155

['build_for_tool=="drmemory"', {

- # Disable the hook based handle verifier, as DrMemory does this job.

- 'win_disable_handle_verifier_hooks': '1',

# These runtime checks force initialization of stack vars which blocks

# DrMemory's uninit detection.

'win_debug_RuntimeChecks': '0',

« no previous file with comments | « base/win/scoped_handle_unittest.cc ('k') | chrome/app/chrome_main_delegate.cc » ('j') | no next file with comments »