Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1664)

Unified Diff: base/debug/close_handle_hook_win.cc

Issue 1678553002: Revert of Enable handle verifier for tests and add some tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/base.gyp ('k') | base/test/test_suite.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug/close_handle_hook_win.cc
diff --git a/base/debug/close_handle_hook_win.cc b/base/debug/close_handle_hook_win.cc
index 0d617b5af62ca7b8c592967cb3d207957cf01bae..6ff6fa2d815f49aa8bed83ed4c0a9f57993a676f 100644
--- a/base/debug/close_handle_hook_win.cc
+++ b/base/debug/close_handle_hook_win.cc
@@ -17,7 +17,6 @@
#include "base/win/iat_patch_function.h"
#include "base/win/pe_image.h"
#include "base/win/scoped_handle.h"
-#include "base/win/windows_version.h"
#include "build/build_config.h"
namespace {
@@ -260,19 +259,12 @@
} // namespace
void InstallHandleHooks() {
-#if !defined(DISABLE_HANDLE_VERIFIER_HOOKS)
-#if defined(_DEBUG)
- // Handle hooks cause shutdown asserts in Debug on Windows 7. crbug.com/571304
- if (base::win::GetVersion() < base::win::VERSION_WIN8)
- return;
-#endif
HandleHooks* hooks = g_hooks.Pointer();
// Performing EAT interception first is safer in the presence of other
// threads attempting to call CloseHandle.
hooks->AddEATPatch();
PatchLoadedModules(hooks);
-#endif
}
void RemoveHandleHooks() {
« no previous file with comments | « base/base.gyp ('k') | base/test/test_suite.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698