Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Side by Side Diff: base/BUILD.gn

Issue 1678553002: Revert of Enable handle verifier for tests and add some tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/base.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # HOW TO WRITE CONDITIONALS IN THIS FILE 5 # HOW TO WRITE CONDITIONALS IN THIS FILE
6 # ====================================== 6 # ======================================
7 # 7 #
8 # In many other places, one would write a conditional that expresses all the 8 # In many other places, one would write a conditional that expresses all the
9 # cases when a source file is used or unused, and then either add or subtract 9 # cases when a source file is used or unused, and then either add or subtract
10 # it from the sources list in that case 10 # it from the sources list in that case
11 # 11 #
12 # Since base includes so many low-level things that vary widely and 12 # Since base includes so many low-level things that vary widely and
13 # unpredictably for the various build types, we prefer a slightly different 13 # unpredictably for the various build types, we prefer a slightly different
14 # style. Instead, there are big per-platform blocks of inclusions and 14 # style. Instead, there are big per-platform blocks of inclusions and
15 # exclusions. If a given file has an inclusion or exclusion rule that applies 15 # exclusions. If a given file has an inclusion or exclusion rule that applies
16 # for multiple conditions, perfer to duplicate it in both lists. This makes it 16 # for multiple conditions, perfer to duplicate it in both lists. This makes it
17 # a bit easier to see which files apply in which cases rather than having a 17 # a bit easier to see which files apply in which cases rather than having a
18 # huge sequence of random-looking conditionals. 18 # huge sequence of random-looking conditionals.
19 19
20 import("//build/buildflag_header.gni") 20 import("//build/buildflag_header.gni")
21 import("//build/config/compiler/compiler.gni") 21 import("//build/config/compiler/compiler.gni")
22 import("//build/config/nacl/config.gni") 22 import("//build/config/nacl/config.gni")
23 import("//build/config/ui.gni") 23 import("//build/config/ui.gni")
24 import("//build/nocompile.gni") 24 import("//build/nocompile.gni")
25 import("//testing/test.gni") 25 import("//testing/test.gni")
26 26
27 declare_args() {
28 # Whether to disable the handle verifier hooks.
29 # Hookless parts of the handle verifier will still function.
30 win_disable_handle_verifier_hooks = false
31 }
32
33 if (is_android) { 27 if (is_android) {
34 import("//build/config/android/rules.gni") 28 import("//build/config/android/rules.gni")
35 } 29 }
36 30
37 config("base_flags") { 31 config("base_flags") {
38 if (is_clang) { 32 if (is_clang) {
39 cflags = [ 33 cflags = [
40 # Don't die on dtoa code that uses a char as an array index. 34 # Don't die on dtoa code that uses a char as an array index.
41 # This is required solely for base/third_party/dmg_fp/dtoa_wrapper.cc. 35 # This is required solely for base/third_party/dmg_fp/dtoa_wrapper.cc.
42 "-Wno-char-subscripts", 36 "-Wno-char-subscripts",
(...skipping 1069 matching lines...) Expand 10 before | Expand all | Expand 10 after
1112 # Not using sha1_win.cc because it may have caused a 1106 # Not using sha1_win.cc because it may have caused a
1113 # regression to page cycler moz. 1107 # regression to page cycler moz.
1114 "sha1_win.cc", 1108 "sha1_win.cc",
1115 ] 1109 ]
1116 1110
1117 # Required for base/stack_trace_win.cc to symbolize correctly. 1111 # Required for base/stack_trace_win.cc to symbolize correctly.
1118 data += [ "$root_build_dir/dbghelp.dll" ] 1112 data += [ "$root_build_dir/dbghelp.dll" ]
1119 1113
1120 deps += [ "//base/trace_event/etw_manifest:chrome_events_win" ] 1114 deps += [ "//base/trace_event/etw_manifest:chrome_events_win" ]
1121 1115
1122 if (is_win && win_disable_handle_verifier_hooks) {
1123 defines += [ "DISABLE_HANDLE_VERIFIER_HOOKS" ]
1124 }
1125
1126 if (is_component_build) { 1116 if (is_component_build) {
1127 # Copy the VS runtime DLLs into the isolate so that they don't have to be 1117 # Copy the VS runtime DLLs into the isolate so that they don't have to be
1128 # preinstalled on the target machine. The debug runtimes have a "d" at 1118 # preinstalled on the target machine. The debug runtimes have a "d" at
1129 # the end. 1119 # the end.
1130 if (is_debug) { 1120 if (is_debug) {
1131 vcrt_suffix = "d" 1121 vcrt_suffix = "d"
1132 } else { 1122 } else {
1133 vcrt_suffix = "" 1123 vcrt_suffix = ""
1134 } 1124 }
1135 1125
(...skipping 749 matching lines...) Expand 10 before | Expand all | Expand 10 after
1885 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] 1875 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
1886 1876
1887 # Symbols for crashes when running tests on swarming. 1877 # Symbols for crashes when running tests on swarming.
1888 if (symbol_level > 0) { 1878 if (symbol_level > 0) {
1889 if (is_win) { 1879 if (is_win) {
1890 data += [ "$root_out_dir/base_unittests.exe.pdb" ] 1880 data += [ "$root_out_dir/base_unittests.exe.pdb" ]
1891 } else if (is_mac) { 1881 } else if (is_mac) {
1892 data += [ "$root_out_dir/base_unittests.dSYM/" ] 1882 data += [ "$root_out_dir/base_unittests.dSYM/" ]
1893 } 1883 }
1894 } 1884 }
1895
1896 # This disables one of the handle verifier tests.
1897 if (is_win && win_disable_handle_verifier_hooks) {
1898 defines = [ "DISABLE_HANDLE_VERIFIER_HOOKS" ]
1899 }
1900 } 1885 }
1901 1886
1902 if (enable_nocompile_tests) { 1887 if (enable_nocompile_tests) {
1903 nocompile_test("base_nocompile_tests") { 1888 nocompile_test("base_nocompile_tests") {
1904 sources = [ 1889 sources = [
1905 "bind_unittest.nc", 1890 "bind_unittest.nc",
1906 "callback_list_unittest.nc", 1891 "callback_list_unittest.nc",
1907 "callback_unittest.nc", 1892 "callback_unittest.nc",
1908 "memory/scoped_ptr_unittest.nc", 1893 "memory/scoped_ptr_unittest.nc",
1909 "memory/weak_ptr_unittest.nc", 1894 "memory/weak_ptr_unittest.nc",
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
2062 2047
2063 # GYP: //base.gyp:base_java_unittest_support 2048 # GYP: //base.gyp:base_java_unittest_support
2064 android_library("base_java_unittest_support") { 2049 android_library("base_java_unittest_support") {
2065 deps = [ 2050 deps = [
2066 ":base_java", 2051 ":base_java",
2067 ] 2052 ]
2068 java_files = 2053 java_files =
2069 [ "test/android/java/src/org/chromium/base/ContentUriTestUtils.java" ] 2054 [ "test/android/java/src/org/chromium/base/ContentUriTestUtils.java" ]
2070 } 2055 }
2071 } 2056 }
OLDNEW
« no previous file with comments | « no previous file | base/base.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698