Issue 167823002: Revert 251327 "Reland of: Split out InputMethodMenuManager from ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 167823002: Revert 251327 "Reland of: Split out InputMethodMenuManager from ..." (Closed)

Created:
6 years, 10 months ago by Lei Zhang

Modified:
6 years, 10 months ago

Reviewers:
Junichi Uekawa

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 251327 "Reland of: Split out InputMethodMenuManager from ..." > Reland of: Split out InputMethodMenuManager from InputMethodManager. > > Rename input_method_property to input_method_menu_item, and move to ash/ime. > > This is a reland of https://codereview.chromium.org/150203015,reverted by https://codereview.chromium.org/165453002 > > Use Singleton<> instead of trying to maintain my own singleton. > > BUG=342336, 343044 > > Review URL: https://codereview.chromium.org/165783002 TBR=uekawa@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251436

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+161 lines, -452 lines)			Patch
trunk/src/ash/ash.gyp	View	2 chunks	+0 lines, -6 lines	0 comments	Download
trunk/src/ash/ime/input_method_menu_item.h	View	1 chunk	+0 lines, -44 lines	0 comments	Download
trunk/src/ash/ime/input_method_menu_item.cc	View	1 chunk	+0 lines, -54 lines	0 comments	Download
trunk/src/ash/ime/input_method_menu_item_unittest.cc	View	1 chunk	+0 lines, -32 lines	0 comments	Download
trunk/src/ash/ime/input_method_menu_manager.h	View	1 chunk	+0 lines, -65 lines	0 comments	Download
trunk/src/ash/ime/input_method_menu_manager.cc	View	1 chunk	+0 lines, -57 lines	0 comments	Download
trunk/src/ash/ime/input_method_menu_manager_unittest.cc	View	1 chunk	+0 lines, -76 lines	0 comments	Download
trunk/src/chrome/browser/chromeos/extensions/input_method_event_router.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
trunk/src/chrome/browser/chromeos/input_method/accessibility.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
trunk/src/chrome/browser/chromeos/input_method/accessibility.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
trunk/src/chrome/browser/chromeos/input_method/input_method_engine.h	View	2 chunks	+3 lines, -8 lines	0 comments	Download
trunk/src/chrome/browser/chromeos/input_method/input_method_engine.cc	View	3 chunks	+9 lines, -10 lines	0 comments	Download
trunk/src/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc	View	2 chunks	+2 lines, -5 lines	0 comments	Download
trunk/src/chrome/browser/chromeos/input_method/input_method_manager_impl.h	View	4 chunks	+11 lines, -1 line	0 comments	Download
trunk/src/chrome/browser/chromeos/input_method/input_method_manager_impl.cc	View	5 chunks	+33 lines, -16 lines	0 comments	Download
trunk/src/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc	View	10 chunks	+44 lines, -51 lines	0 comments	Download
trunk/src/chrome/browser/chromeos/input_method/input_method_persistence.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
trunk/src/chrome/browser/chromeos/input_method/input_method_persistence.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
trunk/src/chrome/browser/chromeos/input_method/mock_input_method_engine.h	View	1 chunk	+1 line, -6 lines	0 comments	Download
trunk/src/chrome/browser/chromeos/input_method/mock_input_method_manager.h	View	2 chunks	+5 lines, -1 line	0 comments	Download
trunk/src/chrome/browser/chromeos/input_method/mock_input_method_manager.cc	View	2 chunks	+10 lines, -1 line	0 comments	Download
trunk/src/chrome/browser/chromeos/input_method/mode_indicator_controller.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
trunk/src/chrome/browser/chromeos/input_method/mode_indicator_controller.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
trunk/src/chrome/browser/ui/ash/system_tray_delegate_chromeos.h	View	3 chunks	+3 lines, -6 lines	0 comments	Download
trunk/src/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc	View	6 chunks	+11 lines, -15 lines	0 comments	Download
trunk/src/chromeos/chromeos.gyp	View	2 chunks	+3 lines, -0 lines	0 comments	Download
trunk/src/chromeos/ime/input_method_manager.h	View	4 chunks	+11 lines, -1 line	0 comments	Download
trunk/src/chromeos/ime/input_method_property.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
trunk/src/chromeos/ime/input_method_property.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
trunk/src/chromeos/ime/input_method_property_unittest.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

6 years, 10 months ago (2014-02-14 22:44:20 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r251436 (tree was closed).

Expand Messages | Collapse Messages