Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: trunk/src/chrome/browser/chromeos/input_method/input_method_engine.cc

Issue 167823002: Revert 251327 "Reland of: Split out InputMethodMenuManager from ..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/chromeos/input_method/input_method_engine.cc
===================================================================
--- trunk/src/chrome/browser/chromeos/input_method/input_method_engine.cc (revision 251433)
+++ trunk/src/chrome/browser/chromeos/input_method/input_method_engine.cc (working copy)
@@ -14,8 +14,6 @@
#undef RootWindow
#include <map>
-#include "ash/ime/input_method_menu_item.h"
-#include "ash/ime/input_method_menu_manager.h"
#include "ash/shell.h"
#include "base/logging.h"
#include "base/memory/scoped_ptr.h"
@@ -377,17 +375,19 @@
if (!active_)
return false;
- ash::ime::InputMethodMenuItemList menu_item_list;
+ input_method::InputMethodPropertyList property_list;
for (std::vector<MenuItem>::const_iterator item = items.begin();
item != items.end(); ++item) {
- ash::ime::InputMethodMenuItem property;
+ input_method::InputMethodProperty property;
MenuItemToProperty(*item, &property);
- menu_item_list.push_back(property);
+ property_list.push_back(property);
}
- ash::ime::InputMethodMenuManager::GetInstance()->
- SetCurrentInputMethodMenuItemList(
- menu_item_list);
+ input_method::InputMethodManager* manager =
+ input_method::InputMethodManager::Get();
+ if (manager)
+ manager->SetCurrentInputMethodProperties(property_list);
+
return true;
}
@@ -595,10 +595,9 @@
static_cast<int>(anchor_pos));
}
-// TODO(uekawa): rename this method to a more reasonable name.
void InputMethodEngine::MenuItemToProperty(
const MenuItem& item,
- ash::ime::InputMethodMenuItem* property) {
+ input_method::InputMethodProperty* property) {
property->key = item.id;
if (item.modified & MENU_ITEM_MODIFIED_LABEL) {

Powered by Google App Engine
This is Rietveld 408576698