Revert 251164 "Split out InputMethodMenuManager from InputMethod..."

Revert 251164 "Split out InputMethodMenuManager from InputMethod..."

> Split out InputMethodMenuManager from InputMethodManager.
> 
> Rename input_method_property to input_method_menu_item, and move to ash/ime.
> 
> BUG=342336, 343044
> 
> Review URL: https://codereview.chromium.org/150203015

I'm reverting as test appears to be consistently failing:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/39558/steps/ash_unittests/logs/TestUninitializedGet

InputMethodMenuManagerTest.TestUninitializedGet (run #1):
[ RUN      ] InputMethodMenuManagerTest.TestUninitializedGet

[WARNING] ../../testing/gtest/src/gtest-death-test.cc:825:: Death
tests use fork(), which is unsafe particularly in a threaded
context. For this test, Google Test couldn't detect the number of
threads.
../../ash/ime/input_method_menu_manager_unittest.cc:16: Failure
Death test: InputMethodMenuManager::Get()
    Result: failed to die.
 Error msg:
[  DEATH   ] 
[  FAILED  ] InputMethodMenuManagerTest.TestUninitializedGet (4 ms)

InputMethodMenuManagerTest.TestUninitializedGet (run #2):
[ RUN      ] InputMethodMenuManagerTest.TestUninitializedGet

[WARNING] ../../testing/gtest/src/gtest-death-test.cc:825:: Death
tests use fork(), which is unsafe particularly in a threaded
context. For this test, Google Test couldn't detect the number of
threads.
../../ash/ime/input_method_menu_manager_unittest.cc:16: Failure
Death test: InputMethodMenuManager::Get()
    Result: failed to die.
 Error msg:
[  DEATH   ] 
[  FAILED  ] InputMethodMenuManagerTest.TestUninitializedGet (2 ms)

InputMethodMenuManagerTest.TestUninitializedGet (run #3):
[ RUN      ] InputMethodMenuManagerTest.TestUninitializedGet

[WARNING] ../../testing/gtest/src/gtest-death-test.cc:825:: Death
tests use fork(), which is unsafe particularly in a threaded
context. For this test, Google Test couldn't detect the number of
threads.
../../ash/ime/input_method_menu_manager_unittest.cc:16: Failure
Death test: InputMethodMenuManager::Get()
    Result: failed to die.
 Error msg:
[  DEATH   ] 
[  FAILED  ] InputMethodMenuManagerTest.TestUninitializedGet (2 ms)

InputMethodMenuManagerTest.TestUninitializedGet (run #4):
[ RUN      ] InputMethodMenuManagerTest.TestUninitializedGet

[WARNING] ../../testing/gtest/src/gtest-death-test.cc:825:: Death
tests use fork(), which is unsafe particularly in a threaded
context. For this test, Google Test couldn't detect the number of
threads.
../../ash/ime/input_method_menu_manager_unittest.cc:16: Failure
Death test: InputMethodMenuManager::Get()
    Result: failed to die.
 Error msg:
[  DEATH   ] 
[  FAILED  ] InputMethodMenuManagerTest.TestUninitializedGet (1 ms)

TBR=uekawa@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251194

[sky, 2014-02-14 00:01:19]

Committed patchset #1 manually as r251194.

[Junichi Uekawa, 2014-02-14 01:55:14]

Hi,

Thanks for the rollback,
I wonder why it passed the commit queue.



2014-02-14 9:01 GMT+09:00 <sky@chromium.org>:

> Committed patchset #1 manually as r251194.
>
> https://codereview.chromium.org/165453002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.