Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 165783002: Reland of: Split out InputMethodMenuManager from InputMethodManager. (Closed)

Created:
6 years, 10 months ago by Junichi Uekawa
Modified:
6 years, 10 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, nkostylev+watch_chromium.org, plundblad+watch_chromium.org, yukishiino+watch_chromium.org, aboxhall+watch_chromium.org, dmazzoni+watch_chromium.org, yuzo+watch_chromium.org, dtseng+watch_chromium.org, nona+watch_chromium.org, ben+ash_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Reland of: Split out InputMethodMenuManager from InputMethodManager. Rename input_method_property to input_method_menu_item, and move to ash/ime. This is a reland of https://codereview.chromium.org/150203015,reverted by https://codereview.chromium.org/165453002 Use Singleton<> instead of trying to maintain my own singleton. BUG=342336, 343044 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251327

Patch Set 1 #

Patch Set 2 : fix unit test #

Patch Set 3 : #

Patch Set 4 : fix compile #

Total comments: 2

Patch Set 5 : review comment; spelling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+385 lines, -321 lines) Patch
ash/ash.gyp View 2 chunks +6 lines, -0 lines 0 comments Download
ash/ime/input_method_menu_item.h View 2 chunks +16 lines, -16 lines 0 comments Download
ash/ime/input_method_menu_item.cc View 3 chunks +12 lines, -12 lines 0 comments Download
ash/ime/input_method_menu_item_unittest.cc View 1 chunk +32 lines, -0 lines 0 comments Download
ash/ime/input_method_menu_manager.h View 1 2 3 4 1 chunk +65 lines, -0 lines 0 comments Download
ash/ime/input_method_menu_manager.cc View 1 chunk +57 lines, -0 lines 0 comments Download
ash/ime/input_method_menu_manager_unittest.cc View 1 chunk +76 lines, -0 lines 0 comments Download
chrome/browser/chromeos/extensions/input_method_event_router.h View 1 chunk +0 lines, -2 lines 0 comments Download
chrome/browser/chromeos/input_method/accessibility.h View 1 chunk +0 lines, -2 lines 0 comments Download
chrome/browser/chromeos/input_method/accessibility.cc View 1 chunk +0 lines, -4 lines 0 comments Download
chrome/browser/chromeos/input_method/input_method_engine.h View 2 chunks +8 lines, -3 lines 0 comments Download
chrome/browser/chromeos/input_method/input_method_engine.cc View 3 chunks +10 lines, -9 lines 0 comments Download
chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
chrome/browser/chromeos/input_method/input_method_manager_impl.h View 4 chunks +1 line, -11 lines 0 comments Download
chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 5 chunks +16 lines, -33 lines 0 comments Download
chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc View 1 2 3 10 chunks +51 lines, -44 lines 0 comments Download
chrome/browser/chromeos/input_method/input_method_persistence.h View 1 chunk +0 lines, -1 line 0 comments Download
chrome/browser/chromeos/input_method/input_method_persistence.cc View 1 chunk +0 lines, -3 lines 0 comments Download
chrome/browser/chromeos/input_method/mock_input_method_engine.h View 1 chunk +6 lines, -1 line 0 comments Download
chrome/browser/chromeos/input_method/mock_input_method_manager.h View 2 chunks +1 line, -5 lines 0 comments Download
chrome/browser/chromeos/input_method/mock_input_method_manager.cc View 2 chunks +1 line, -10 lines 0 comments Download
chrome/browser/chromeos/input_method/mode_indicator_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
chrome/browser/chromeos/input_method/mode_indicator_controller.cc View 1 chunk +0 lines, -5 lines 0 comments Download
chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 3 chunks +6 lines, -3 lines 0 comments Download
chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 6 chunks +15 lines, -11 lines 0 comments Download
chromeos/chromeos.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
chromeos/ime/input_method_manager.h View 4 chunks +1 line, -11 lines 0 comments Download
chromeos/ime/input_method_property.h View 1 chunk +0 lines, -44 lines 0 comments Download
chromeos/ime/input_method_property.cc View 1 chunk +0 lines, -54 lines 0 comments Download
chromeos/ime/input_method_property_unittest.cc View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Junichi Uekawa
Hi, This is a retry of the change using Singleton GetInstance() instead of rolling my ...
6 years, 10 months ago (2014-02-14 02:23:37 UTC) #1
Daniel Erat
lgtm for chrome/browser/ui/ash
6 years, 10 months ago (2014-02-14 04:57:31 UTC) #2
Seigo Nonaka
lgtm thanks. https://codereview.chromium.org/165783002/diff/80001/ash/ime/input_method_menu_manager.h File ash/ime/input_method_menu_manager.h (right): https://codereview.chromium.org/165783002/diff/80001/ash/ime/input_method_menu_manager.h#newcode34 ash/ime/input_method_menu_manager.h:34: // Obtain the singleton instance. nit: /Obtain/Obtains/?
6 years, 10 months ago (2014-02-14 07:46:59 UTC) #3
Junichi Uekawa
https://codereview.chromium.org/165783002/diff/80001/ash/ime/input_method_menu_manager.h File ash/ime/input_method_menu_manager.h (right): https://codereview.chromium.org/165783002/diff/80001/ash/ime/input_method_menu_manager.h#newcode34 ash/ime/input_method_menu_manager.h:34: // Obtain the singleton instance. On 2014/02/14 07:47:00, Seigo ...
6 years, 10 months ago (2014-02-14 08:01:46 UTC) #4
Junichi Uekawa
The CQ bit was checked by uekawa@chromium.org
6 years, 10 months ago (2014-02-14 08:02:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/uekawa@chromium.org/165783002/130001
6 years, 10 months ago (2014-02-14 08:02:36 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 10:23:01 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) ash_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=264164
6 years, 10 months ago (2014-02-14 10:23:02 UTC) #8
Junichi Uekawa
The CQ bit was checked by uekawa@chromium.org
6 years, 10 months ago (2014-02-14 11:49:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/uekawa@chromium.org/165783002/130001
6 years, 10 months ago (2014-02-14 11:50:08 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 15:16:54 UTC) #11
Message was sent while issue was closed. 
Change committed as 251327

Powered by Google App Engine
This is Rietveld 408576698