Change assert to release assert for WTF::double_conversion::Vector to prevent OOB memory access.

Change assert to release assert for WTF::double_conversion::Vector to prevent OOB memory access.

R=inferno@chromium.org, mbarbella@chromium.org, ochang@chromium.org, tkent@chromium.org
BUG=574802
Committed: https://crrev.com/ad618c3357e189fb685ea88fe4b8b25ac34f2c75
Cr-Commit-Position: refs/heads/master@{#374424}

[Oliver Chang, 2016-02-09 01:29:08]

lgtm

[tkent, 2016-02-09 01:31:13]

Can we remove this Vector and use WTF::Vector?

[mmoroz, 2016-02-09 01:55:33]

On 2016/02/09 01:31:13, tkent wrote:
> Can we remove this Vector and use WTF::Vector?

As I see, this light-weight Vector implementation is used only inside
double_conversion namespace. May be it is the reason why it was originally
implemented - to do not use much complex object with unnecessary features.

[tkent, 2016-02-09 04:22:20]

anyway, this is trivial.  lgtm

[inferno, 2016-02-09 04:30:13]

lgtm

https://codereview.chromium.org/1677363002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/dtoa/utils.h (right):

https://codereview.chromium.org/1677363002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/dtoa/utils.h:166: // Access individual vector
elements - checks bounds in debug mode.
Please fix the comment.

[mmoroz, 2016-02-09 16:50:55]

Thanks!

https://codereview.chromium.org/1677363002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/dtoa/utils.h (right):

https://codereview.chromium.org/1677363002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/dtoa/utils.h:166: // Access individual vector
elements - checks bounds in debug mode.
On 2016/02/09 04:30:12, inferno wrote:
> Please fix the comment.

Done.

[mmoroz, 2016-02-09 16:51:06]

The CQ bit was checked by mmoroz@chromium.org

[mmoroz, 2016-02-09 16:51:07]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
ochang@chromium.org, inferno@chromium.org
Link to the patchset: https://codereview.chromium.org/1677363002/#ps20001
(title: "fix comment")

[commit-bot: I haz the power, 2016-02-09 16:52:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1677363002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1677363002/20001

[commit-bot: I haz the power, 2016-02-09 18:50:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-09 18:51:41]

Description was changed from

==========
Change assert to release assert for WTF::double_conversion::Vector to prevent
OOB memory access.

R=inferno@chromium.org, mbarbella@chromium.org, ochang@chromium.org,
tkent@chromium.org
BUG=574802
==========

to

==========
Change assert to release assert for WTF::double_conversion::Vector to prevent
OOB memory access.

R=inferno@chromium.org, mbarbella@chromium.org, ochang@chromium.org,
tkent@chromium.org
BUG=574802

Committed: https://crrev.com/ad618c3357e189fb685ea88fe4b8b25ac34f2c75
Cr-Commit-Position: refs/heads/master@{#374424}
==========

[commit-bot: I haz the power, 2016-02-09 18:51:42]

Patchset 2 (id:??) landed as
https://crrev.com/ad618c3357e189fb685ea88fe4b8b25ac34f2c75
Cr-Commit-Position: refs/heads/master@{#374424}

[mmoroz, 2016-02-09 18:52:31]

On 2016/02/09 18:51:42, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/ad618c3357e189fb685ea88fe4b8b25ac34f2c75
> Cr-Commit-Position: refs/heads/master@{#374424}

Link to performance dashboard (is empty right now):
https://chromeperf.appspot.com/group_report?rev=374424

[inferno, 2016-02-14 16:55:13]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1694093002/ by inferno@chromium.org.

The reason for reverting is: Perf failures. Speculative revert to see if it
fixes.

BUG=586581,574802.