Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: third_party/WebKit/Source/wtf/dtoa/utils.h

Issue 1677363002: Change assert to release assert for WTF::double_conversion::Vector to prevent OOB memory access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/wtf/dtoa/utils.h
diff --git a/third_party/WebKit/Source/wtf/dtoa/utils.h b/third_party/WebKit/Source/wtf/dtoa/utils.h
index 0a61c0155f74a499171e44c9fc35008e4f5b7b4b..dcc433f1ba3fd64130546a554a4d0ff283542244 100644
--- a/third_party/WebKit/Source/wtf/dtoa/utils.h
+++ b/third_party/WebKit/Source/wtf/dtoa/utils.h
@@ -163,9 +163,9 @@ namespace double_conversion {
// Returns the pointer to the start of the data in the vector.
T* start() const { return start_; }
- // Access individual vector elements - checks bounds in debug mode.
+ // Access individual vector elements.
T& operator[](int index) const {
- ASSERT(0 <= index && index < length_);
+ RELEASE_ASSERT(0 <= index && index < length_);
return start_[index];
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698