Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1694093002: Revert of Change assert to release assert for WTF::double_conversion::Vector to prevent OOB memory access. (Closed)

Created:
4 years, 10 months ago by inferno
Modified:
4 years, 10 months ago
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change assert to release assert for WTF::double_conversion::Vector to prevent OOB memory access. (patchset #2 id:20001 of https://codereview.chromium.org/1677363002/ ) Reason for revert: Perf failures. Speculative revert to see if it fixes. BUG=586581, 574802 Original issue's description: > Change assert to release assert for WTF::double_conversion::Vector to prevent OOB memory access. > > R=inferno@chromium.org, mbarbella@chromium.org, ochang@chromium.org, tkent@chromium.org > BUG=574802 > > Committed: https://crrev.com/ad618c3357e189fb685ea88fe4b8b25ac34f2c75 > Cr-Commit-Position: refs/heads/master@{#374424} TBR=mbarbella@chromium.org,ochang@chromium.org,tkent@chromium.org,mmoroz@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=574802 Committed: https://crrev.com/64cb1f5327522142c658100746f34f8a012a45fa Cr-Commit-Position: refs/heads/master@{#375389}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/wtf/dtoa/utils.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
inferno
Created Revert of Change assert to release assert for WTF::double_conversion::Vector to prevent OOB memory access.
4 years, 10 months ago (2016-02-14 16:55:14 UTC) #1
inferno
4 years, 10 months ago (2016-02-17 22:59:25 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1708703003/ by inferno@chromium.org.

The reason for reverting is: This revert was not the culprit CL. Reverting the
revert..

Powered by Google App Engine
This is Rietveld 408576698