Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1675443002: Delete the GPU recipe and code that only it depended on. (Closed)

Created:
4 years, 10 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 10 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, luqui, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Delete the GPU recipe and code that only it depended on. It's now unreferenced by the bots. A couple of tests were either copied from the GPU recipe, or modified, in order to regain code coverage. A few small TODOs were added about adding tests to regain coverage for a few other lines. BUG=542370 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298605

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed iannucci's review feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -29434 lines) Patch
M scripts/slave/recipe_modules/chromium/api.py View 1 5 chunks +5 lines, -33 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.py View 1 1 chunk +0 lines, -4 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/test_api.py View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/steps.py View 1 4 chunks +5 lines, -19 lines 0 comments Download
D scripts/slave/recipe_modules/gpu/OWNERS View 1 1 chunk +0 lines, -3 lines 0 comments Download
D scripts/slave/recipe_modules/gpu/__init__.py View 1 1 chunk +0 lines, -21 lines 0 comments Download
D scripts/slave/recipe_modules/gpu/api.py View 1 1 chunk +0 lines, -603 lines 0 comments Download
D scripts/slave/recipe_modules/gpu/common.py View 1 1 chunk +0 lines, -76 lines 0 comments Download
D scripts/slave/recipe_modules/gpu/test_api.py View 1 1 chunk +0 lines, -73 lines 0 comments Download
M scripts/slave/recipe_modules/isolate/api.py View 1 2 chunks +0 lines, -40 lines 0 comments Download
M scripts/slave/recipes/chromium.py View 1 1 chunk +26 lines, -0 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test_harness_failure_zero_retcode.json View 1 3 chunks +10 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.py View 1 9 chunks +3 lines, -62 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/analyze_runs_nothing.json View 1 1 chunk +0 lines, -280 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/analyze_runs_only_angle_unittests.json View 1 1 chunk +0 lines, -337 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/blink_compile_without_patch_fails.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/blink_minimal_pass_continues.json View 1 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_failure_without_patch_deapply_fn.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/dont_analyze_for_non_src_project.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_dbg.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_dbg_fail.json View 1 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_dbg_pass.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_oilpan_dbg.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_oilpan_dbg_fail.json View 1 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_oilpan_dbg_pass.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_oilpan_rel.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_oilpan_rel_fail.json View 1 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_oilpan_rel_pass.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_rel.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_rel_fail.json View 1 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_rel_ng.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_rel_ng_fail.json View 1 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_rel_ng_pass.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_rel_pass.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_dbg.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_dbg_fail.json View 1 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_dbg_pass.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_oilpan_dbg.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_oilpan_dbg_fail.json View 1 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_oilpan_dbg_pass.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_oilpan_rel.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_oilpan_rel_fail.json View 1 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_oilpan_rel_pass.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_rel.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_rel_fail.json View 1 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_rel_pass.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_dbg.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_dbg_fail.json View 1 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_dbg_pass.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_oilpan_dbg.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_oilpan_dbg_fail.json View 1 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_oilpan_dbg_pass.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_oilpan_rel.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_oilpan_rel_fail.json View 1 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_oilpan_rel_pass.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_rel.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_rel_fail.json View 1 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_rel_pass.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_practice_rel_ng.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_site_isolation.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_v8_v8_linux_blink_rel.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/invalid_results.json View 1 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/non_cq_blink_tryjob.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/too_many_failures_for_retcode.json View 1 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_blink_trybot_test_failures.json View 1 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/webkit_tests_interrupted.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/webkit_tests_unexpected_error.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
D scripts/slave/recipes/gpu/OWNERS View 1 1 chunk +0 lines, -3 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_test.py View 1 1 chunk +0 lines, -145 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_test.expected/killall_gnome_keyring_failure.json View 1 1 chunk +0 lines, -940 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_test.expected/linux_debug.json View 1 1 chunk +0 lines, -671 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_test.expected/linux_debug_blink.json View 1 1 chunk +0 lines, -674 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_test.expected/linux_debug_tryserver.json View 1 1 chunk +0 lines, -776 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_test.expected/linux_release.json View 1 1 chunk +0 lines, -707 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_test.expected/linux_release_blink.json View 1 1 chunk +0 lines, -710 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_test.expected/linux_release_fyi.json View 1 1 chunk +0 lines, -937 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_test.expected/linux_release_tryserver.json View 1 1 chunk +0 lines, -812 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_test.expected/mac_debug.json View 1 1 chunk +0 lines, -678 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_test.expected/mac_debug_blink.json View 1 1 chunk +0 lines, -681 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_test.expected/mac_debug_tryserver.json View 1 1 chunk +0 lines, -783 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_test.expected/mac_release.json View 1 1 chunk +0 lines, -713 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_test.expected/mac_release_blink.json View 1 1 chunk +0 lines, -716 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_test.expected/mac_release_git.json View 1 1 chunk +0 lines, -713 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_test.expected/mac_release_skip_checkout.json View 1 1 chunk +0 lines, -615 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_test.expected/mac_release_skip_compile.json View 1 1 chunk +0 lines, -600 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_test.expected/mac_release_tryserver.json View 1 1 chunk +0 lines, -818 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_test.expected/mac_release_tryserver_blink.json View 1 1 chunk +0 lines, -821 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_test.expected/win_debug.json View 1 1 chunk +0 lines, -658 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_test.expected/win_debug_blink.json View 1 1 chunk +0 lines, -661 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_test.expected/win_debug_tryserver.json View 1 1 chunk +0 lines, -763 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_test.expected/win_release.json View 1 1 chunk +0 lines, -693 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_test.expected/win_release_blink.json View 1 1 chunk +0 lines, -696 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_test.expected/win_release_fyi.json View 1 1 chunk +0 lines, -1055 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_test.expected/win_release_tryserver.json View 1 1 chunk +0 lines, -798 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_upload.py View 1 1 chunk +0 lines, -108 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_upload.expected/analyze_builds_nothing.json View 1 1 chunk +0 lines, -210 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_upload.expected/analyze_builds_only_angle_unittests.json View 1 1 chunk +0 lines, -280 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_upload.expected/compile_fail_is_critical_on_main.json View 1 1 chunk +0 lines, -176 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_upload.expected/compile_with_patch_fail.json View 1 1 chunk +0 lines, -438 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_upload.expected/compile_without_patch_fail.json View 1 1 chunk +0 lines, -442 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_upload.expected/linux_debug.json View 1 1 chunk +0 lines, -207 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_upload.expected/linux_release.json View 1 1 chunk +0 lines, -207 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_upload.expected/mac_debug.json View 1 1 chunk +0 lines, -227 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_upload.expected/mac_release.json View 1 1 chunk +0 lines, -227 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_upload.expected/win_debug.json View 1 1 chunk +0 lines, -207 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_upload.expected/win_release.json View 1 1 chunk +0 lines, -207 lines 0 comments Download
D scripts/slave/recipes/gpu/build_and_upload.expected/win_release_tot_angle.json View 1 1 chunk +0 lines, -225 lines 0 comments Download
D scripts/slave/recipes/gpu/download_and_test.py View 1 1 chunk +0 lines, -132 lines 0 comments Download
D scripts/slave/recipes/gpu/download_and_test.expected/failures_keeps_going.json View 1 1 chunk +0 lines, -604 lines 0 comments Download
D scripts/slave/recipes/gpu/download_and_test.expected/linux_debug.json View 1 1 chunk +0 lines, -563 lines 0 comments Download
D scripts/slave/recipes/gpu/download_and_test.expected/linux_release.json View 1 1 chunk +0 lines, -600 lines 0 comments Download
D scripts/slave/recipes/gpu/download_and_test.expected/linux_release_deqp.json View 1 1 chunk +0 lines, -141 lines 0 comments Download
D scripts/slave/recipes/gpu/download_and_test.expected/mac_debug.json View 1 1 chunk +0 lines, -550 lines 0 comments Download
D scripts/slave/recipes/gpu/download_and_test.expected/mac_release.json View 1 1 chunk +0 lines, -586 lines 0 comments Download
D scripts/slave/recipes/gpu/download_and_test.expected/telemetry_gpu_test_harness_failure.json View 1 1 chunk +0 lines, -602 lines 0 comments Download
D scripts/slave/recipes/gpu/download_and_test.expected/telemetry_gpu_test_harness_failure_zero_retcode.json View 1 1 chunk +0 lines, -604 lines 0 comments Download
D scripts/slave/recipes/gpu/download_and_test.expected/win_debug.json View 1 1 chunk +0 lines, -563 lines 0 comments Download
D scripts/slave/recipes/gpu/download_and_test.expected/win_release.json View 1 1 chunk +0 lines, -599 lines 0 comments Download
D scripts/slave/recipes/gpu/download_and_test.expected/win_release_deqp.json View 1 1 chunk +0 lines, -180 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Ken Russell (switch to Gerrit)
Pawel and CQ team: please review this large deletion. (This touches chromium_tests, so your review ...
4 years, 10 months ago (2016-02-04 23:59:14 UTC) #2
Sergey Berezin
LGTM for chromium_tests/steps.py, chromium.py and chromium_trybot.py. Thanks!
4 years, 10 months ago (2016-02-05 00:08:28 UTC) #3
Ken Russell (switch to Gerrit)
Robbie: now that Sergey has reviewed the chromium_tests and related code, would you review the ...
4 years, 10 months ago (2016-02-05 00:09:28 UTC) #5
iannucci
lgtm woohoo!!! https://codereview.chromium.org/1675443002/diff/1/scripts/slave/recipes/chromium_trybot.py File scripts/slave/recipes/chromium_trybot.py (right): https://codereview.chromium.org/1675443002/diff/1/scripts/slave/recipes/chromium_trybot.py#newcode252 scripts/slave/recipes/chromium_trybot.py:252: swarm_hashes = dict() {}
4 years, 10 months ago (2016-02-05 00:33:04 UTC) #6
Ken Russell (switch to Gerrit)
https://codereview.chromium.org/1675443002/diff/1/scripts/slave/recipes/chromium_trybot.py File scripts/slave/recipes/chromium_trybot.py (right): https://codereview.chromium.org/1675443002/diff/1/scripts/slave/recipes/chromium_trybot.py#newcode252 scripts/slave/recipes/chromium_trybot.py:252: swarm_hashes = dict() On 2016/02/05 00:33:03, iannucci wrote: > ...
4 years, 10 months ago (2016-02-05 00:45:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675443002/10001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675443002/10001
4 years, 10 months ago (2016-02-05 00:48:10 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 00:52:08 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:10001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298605

Powered by Google App Engine
This is Rietveld 408576698