Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: scripts/slave/recipe_modules/isolate/api.py

Issue 1675443002: Delete the GPU recipe and code that only it depended on. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Addressed iannucci's review feedback. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/recipe_modules/gpu/test_api.py ('k') | scripts/slave/recipes/chromium.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/isolate/api.py
diff --git a/scripts/slave/recipe_modules/isolate/api.py b/scripts/slave/recipe_modules/isolate/api.py
index f24b476d9d3fa8646d544db5f1ad8cd7d810ee83..69d7836af3337924e7e345d65defb86790140fc8 100644
--- a/scripts/slave/recipe_modules/isolate/api.py
+++ b/scripts/slave/recipe_modules/isolate/api.py
@@ -191,28 +191,6 @@ class IsolateApi(recipe_api.RecipeApi):
"""Returns the path to run_isolated.py."""
return self.m.swarming_client.path.join('run_isolated.py')
- def runtest_args_list(self, test, args=None):
- """Array of arguments for running the given test via run_isolated.py.
-
- The test should be already uploaded to the isolated server. The method
- expects to find |test| as a key in the isolated_tests dictionary.
- """
- assert test in self.isolated_tests, (test, self.isolated_tests)
- full_args = [
- '--isolated',
- self.isolated_tests[test],
- '-I',
- self._isolate_server,
- # Always append '--' to the argument list. api.chromium.runtest
- # will add any flags like --gtest_output to the end of the command
- # line. run_isolated.py must treat these as extra arguments to the
- # isolate.
- '--'
- ]
- if args:
- full_args.extend(args)
- return full_args
-
def run_isolated(self, name, isolate_hash, args=None, **kwargs):
"""Runs an isolated test."""
cmd = [
@@ -225,24 +203,6 @@ class IsolateApi(recipe_api.RecipeApi):
cmd.extend(args)
self.m.python(name, self._run_isolated_path, cmd, **kwargs)
- def runtest(self, test, revision, webkit_revision, args=None, name=None,
- **runtest_kwargs):
- """Runs a test which has previously been isolated to the server.
-
- Uses runtest_args_list, above, and delegates to api.chromium.runtest.
-
- DEPRECATED - run_isolated above is strongly recommended for all new callers.
- """
- self.m.chromium.runtest(
- self._run_isolated_path,
- args=self.runtest_args_list(test, args),
- # We must use the name of the test as the name in order to avoid
- # duplicate steps called "run_isolated".
- name=name or test,
- revision=revision,
- webkit_revision=webkit_revision,
- **runtest_kwargs)
-
def remove_build_metadata(self):
"""Removes the build metadata embedded in the build artifacts."""
args = [
« no previous file with comments | « scripts/slave/recipe_modules/gpu/test_api.py ('k') | scripts/slave/recipes/chromium.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698