Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: scripts/slave/recipes/gpu/build_and_upload.py

Issue 1675443002: Delete the GPU recipe and code that only it depended on. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Addressed iannucci's review feedback. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/gpu/build_and_upload.py
diff --git a/scripts/slave/recipes/gpu/build_and_upload.py b/scripts/slave/recipes/gpu/build_and_upload.py
deleted file mode 100644
index c5fee369f1ef28e7e5e204f71336f71f832062de..0000000000000000000000000000000000000000
--- a/scripts/slave/recipes/gpu/build_and_upload.py
+++ /dev/null
@@ -1,108 +0,0 @@
-# Copyright 2013 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-# This recipe is intended to control all of the GPU builders on the
-# following waterfalls:
-# chromium.gpu
-# chromium.gpu.fyi
-# chromium.webkit
-
-DEPS = [
- 'buildbot',
- 'gpu',
- 'recipe_engine/json',
- 'recipe_engine/platform',
- 'recipe_engine/properties',
-]
-
-def RunSteps(api):
- api.gpu.setup()
- api.buildbot.prep()
- api.gpu.checkout_steps()
- api.gpu.compile_steps()
-
-def GenTests(api):
- # The majority of the tests are in the build_and_test recipe.
-
- # Keep the additional properties in sync with the download_and_test
- # recipe in order to catch regressions.
- for plat in ['win', 'mac', 'linux']:
- for flavor in ['Debug', 'Release']:
- flavor_lower = flavor.lower()
- yield (
- api.test('%s_%s' % (plat, flavor_lower)) +
- api.properties.scheduled(
- build_config=flavor,
- mastername='chromium.gpu.testing',
- buildername='%s %s builder' % (plat, flavor_lower),
- buildnumber=571) +
- api.platform.name(plat)
- )
-
- # Test one configuration where it's expected that top-of-tree ANGLE
- # will be used.
- yield (
- api.test('win_release_tot_angle') +
- api.properties.scheduled(
- build_config='Release',
- mastername='chromium.gpu.fyi',
- buildername='win release tot angle builder',
- buildnumber=572) +
- api.platform.name('win')
- )
-
- yield (
- api.test('compile_with_patch_fail') +
- api.properties.tryserver(
- mastername='tryserver.chromium.win',
- buildername='win_chromium_rel_ng') +
- api.override_step_data('analyze', api.gpu.analyze_builds_everything) +
- api.step_data('compile (with patch)', retcode=1) +
- api.platform.name('win')
- )
-
- yield (
- api.test('compile_without_patch_fail') +
- api.properties.tryserver(
- mastername='tryserver.chromium.win',
- buildername='win_chromium_rel_ng') +
- api.override_step_data('analyze', api.gpu.analyze_builds_everything) +
- api.step_data('compile (with patch)', retcode=1) +
- api.step_data('compile (without patch)', retcode=1) +
- api.platform.name('win')
- )
-
- yield (
- api.test('compile_fail_is_critical_on_main') +
- api.properties.scheduled(
- build_config='Release',
- mastername='chromium.gpu.testing',
- buildername='linux release builder',
- buildnumber=571) +
- api.platform.name('linux') +
- api.step_data('compile', retcode=1)
- )
-
- # Tests analyze module exits early if patch can't affect this config.
- yield (
- api.test('analyze_builds_nothing') +
- api.properties.tryserver(
- mastername='tryserver.chromium.win',
- buildername='win_chromium_rel_ng') +
- api.override_step_data(
- 'analyze',
- api.gpu.analyze_builds_nothing)
- )
-
- # Tests that we only build a single isolate if that's all that
- # needed to be rebuilt in a patch.
- yield (
- api.test('analyze_builds_only_angle_unittests') +
- api.properties.tryserver(
- mastername='tryserver.chromium.win',
- buildername='win_chromium_rel_ng') +
- api.override_step_data(
- 'analyze',
- api.gpu.analyze_builds_angle_unittests)
- )

Powered by Google App Engine
This is Rietveld 408576698