Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test_harness_failure_zero_retcode.json

Issue 1675443002: Delete the GPU recipe and code that only it depended on. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Addressed iannucci's review feedback. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/recipes/chromium.py ('k') | scripts/slave/recipes/chromium_trybot.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test_harness_failure_zero_retcode.json
diff --git a/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test.json b/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test_harness_failure_zero_retcode.json
similarity index 90%
copy from scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test.json
copy to scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test_harness_failure_zero_retcode.json
index 322ad5531379649423d0519069527c0276a8ffd0..a7675d33bf7041b5130fddc70c05cc07d0d5be9c 100644
--- a/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test.json
+++ b/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test_harness_failure_zero_retcode.json
@@ -163,19 +163,8 @@
"@@@STEP_LOG_LINE@json.output@ \"Linux Tests\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"isolated_scripts\": [@@@",
"@@@STEP_LOG_LINE@json.output@ {@@@",
- "@@@STEP_LOG_LINE@json.output@ \"args\": [@@@",
- "@@@STEP_LOG_LINE@json.output@ \"--correct-common-arg\"@@@",
- "@@@STEP_LOG_LINE@json.output@ ], @@@",
"@@@STEP_LOG_LINE@json.output@ \"isolate_name\": \"telemetry_gpu_unittests\", @@@",
- "@@@STEP_LOG_LINE@json.output@ \"name\": \"telemetry_gpu_unittests\", @@@",
- "@@@STEP_LOG_LINE@json.output@ \"non_precommit_args\": [@@@",
- "@@@STEP_LOG_LINE@json.output@ \"--these-args-should-be-present\", @@@",
- "@@@STEP_LOG_LINE@json.output@ \"--test-machine-name=\\\"${buildername}\\\"\", @@@",
- "@@@STEP_LOG_LINE@json.output@ \"--build-revision=\\\"${got_revision}\\\"\"@@@",
- "@@@STEP_LOG_LINE@json.output@ ], @@@",
- "@@@STEP_LOG_LINE@json.output@ \"precommit_args\": [@@@",
- "@@@STEP_LOG_LINE@json.output@ \"--SHOULD-NOT-BE-PRESENT-DURING-THE-RUN\"@@@",
- "@@@STEP_LOG_LINE@json.output@ ]@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"name\": \"telemetry_gpu_unittests\"@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
"@@@STEP_LOG_LINE@json.output@ ]@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
@@ -262,10 +251,6 @@
"https://isolateserver.appspot.com",
"--verbose",
"--",
- "--correct-common-arg",
- "--these-args-should-be-present",
- "--test-machine-name=\"Linux Tests\"",
- "--build-revision=\"f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9\"",
"--isolated-script-test-output",
"/path/to/tmp/json"
],
@@ -273,15 +258,19 @@
"name": "telemetry_gpu_unittests",
"~followup_annotations": [
"@@@STEP_LOG_LINE@json.output@{@@@",
- "@@@STEP_LOG_LINE@json.output@ \"failures\": [], @@@",
- "@@@STEP_LOG_LINE@json.output@ \"valid\": true@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"failures\": [@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"test1.Test1\", @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"test2.Test2\"@@@",
+ "@@@STEP_LOG_LINE@json.output@ ], @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"valid\": false@@@",
"@@@STEP_LOG_LINE@json.output@}@@@",
- "@@@STEP_LOG_END@json.output@@@"
+ "@@@STEP_LOG_END@json.output@@@",
+ "@@@STEP_FAILURE@@@"
]
},
{
"name": "$result",
- "recipe_result": null,
- "status_code": 0
+ "reason": "1 tests failed: ['telemetry_gpu_unittests']",
+ "status_code": 1
}
]
« no previous file with comments | « scripts/slave/recipes/chromium.py ('k') | scripts/slave/recipes/chromium_trybot.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698