Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1348)

Issue 1675163002: Rename ComposedTree to FlatTree (Closed)

Created:
4 years, 10 months ago by hayato
Modified:
4 years, 10 months ago
Reviewers:
tkent, yosin_UTC9, kochi
CC:
aboxhall, aboxhall+watch_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, dmazzoni, dmazzoni+watch_chromium.org, krit, dtseng+watch_chromium.org, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, je_julie, kinuko+watch, kouhei+svg_chromium.org, leviw+renderwatch, nektarios, nektar+watch_chromium.org, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, plundblad+watch_chromium.org, rwlbuis, Stephen Chennney, sof, szager+layoutwatch_chromium.org, webcomponents-bugzilla_chromium.org, yuzo+watch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ComposedTree to FlatTree The spec change is: https://github.com/w3c/webcomponents/commit/9b7f16e90b88594ed783ff7e0f971fad084e5f4d Blink should follow the change of the terminologies in the spec. There is no change on web-facing APIs. This CL is the result of the (almost) mechanical renaming, using: > zargs **/*.{h,cpp,gyp,gypi,idl,js,html,txt} -- sed -i -e 's/ComposedTree/FlatTree/g' > zargs **/*.{h,cpp,gyp,gypi,idl,js,html,txt} -- sed -i -e 's/composed tree/flat tree/g' > zargs **/*.{h,cpp,gyp,gypi,idl,js,html,txt} -- sed -i -e 's/Composed tree/Flat tree/g' > zargs **/*.{h,cpp,gyp,gypi,idl,js,html,txt} -- sed -i -e 's/Composed Tree/Flat Tree/g' Other renaming, which would require a more careful investigation, will be done in another CL. BUG=531990 Committed: https://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415 Cr-Commit-Position: refs/heads/master@{#374095}

Patch Set 1 #

Patch Set 2 : wip #

Patch Set 3 : wip #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1077 lines, -2325 lines) Patch
M third_party/WebKit/LayoutTests/editing/selection/double-click-on-shadow-tree.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/text-iterator/findString-shadow-roots.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/attr-dir-inherit.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/attr-title-inherit.html View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/distribution-update-fonts-load.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/focus-navigation.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/getComputedStyle-composed-parent-dirty.html View 1 2 1 chunk +1 line, -1 line 2 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/getComputedStyle-composed-parent-dirty-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/hostcontext-pseudo-class.html View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/hostcontext-pseudo-class-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/resources/event-dispatching.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js View 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/style-with-deep-combinator.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/SelectorChecker.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ElementTraversal.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/LayoutTreeBuilderTraversal.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 9 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/dom/NodeTraversal.h View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/core/dom/shadow/ComposedTreeTraversal.h View 1 chunk +0 lines, -314 lines 0 comments Download
D third_party/WebKit/Source/core/dom/shadow/ComposedTreeTraversal.cpp View 1 chunk +0 lines, -361 lines 0 comments Download
D third_party/WebKit/Source/core/dom/shadow/ComposedTreeTraversalTest.cpp View 1 chunk +0 lines, -573 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversal.h View 1 18 chunks +33 lines, -33 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversal.cpp View 1 21 chunks +31 lines, -31 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversalTest.cpp View 1 15 chunks +94 lines, -94 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStrategy.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStrategy.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStrategyTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.h View 13 chunks +21 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 19 chunks +33 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp View 8 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EphemeralRange.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EphemeralRange.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FindOptions.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.h View 5 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 10 chunks +19 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp View 2 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/editing/PendingSelection.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Position.h View 5 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Position.cpp View 1 6 chunks +20 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/editing/PositionIterator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/PositionIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/PositionTest.cpp View 7 chunks +30 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/editing/PositionWithAffinity.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/PositionWithAffinity.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/RenderedPosition.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/RenderedPosition.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionAdjuster.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp View 9 chunks +52 lines, -52 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionAdjusterTest.cpp View 2 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionController.cpp View 7 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionEditor.h View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionEditor.cpp View 3 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisiblePosition.h View 1 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisiblePosition.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp View 1 10 chunks +75 lines, -75 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.h View 1 5 chunks +41 lines, -41 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 36 chunks +68 lines, -68 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp View 1 32 chunks +166 lines, -166 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/BackwardsCharacterIterator.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/BackwardsCharacterIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/CharacterIterator.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/FullyClippedStateStack.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/FullyClippedStateStack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/SearchBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIteratorTest.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextIterator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp View 1 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextIteratorTest.cpp View 26 chunks +34 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/Serialization.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/Serialization.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializerTest.cpp View 1 18 chunks +27 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSummaryElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTablePartElement.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 11 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/input/TouchActionUtil.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/HitTestResult.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutListItem.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/testing/CoreTestPrinters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.h View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 2 chunks +21 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.idl View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/TextFinder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/TextFinder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebAXObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/TextFinderTest.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 32 (18 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675163002/1
4 years, 10 months ago (2016-02-08 05:28:59 UTC) #2
hayato
wip
4 years, 10 months ago (2016-02-08 05:55:17 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675163002/20001
4 years, 10 months ago (2016-02-08 05:55:41 UTC) #10
hayato
wip
4 years, 10 months ago (2016-02-08 06:09:10 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675163002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675163002/40001
4 years, 10 months ago (2016-02-08 06:09:21 UTC) #15
hayato
PTAL
4 years, 10 months ago (2016-02-08 06:11:05 UTC) #18
kochi
lgtm
4 years, 10 months ago (2016-02-08 06:33:09 UTC) #21
tkent
lgtm https://codereview.chromium.org/1675163002/diff/40001/third_party/WebKit/LayoutTests/fast/dom/shadow/getComputedStyle-composed-parent-dirty.html File third_party/WebKit/LayoutTests/fast/dom/shadow/getComputedStyle-composed-parent-dirty.html (right): https://codereview.chromium.org/1675163002/diff/40001/third_party/WebKit/LayoutTests/fast/dom/shadow/getComputedStyle-composed-parent-dirty.html#newcode1 third_party/WebKit/LayoutTests/fast/dom/shadow/getComputedStyle-composed-parent-dirty.html:1: <!DOCTYPE html> Probably you want to rename this ...
4 years, 10 months ago (2016-02-08 06:42:30 UTC) #22
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-08 07:25:27 UTC) #24
yosin_UTC9
lgtm "Flat Tree" is better than "Flatten Tree", since it is shorter. Switching my brain ...
4 years, 10 months ago (2016-02-08 07:37:18 UTC) #25
hayato
https://codereview.chromium.org/1675163002/diff/40001/third_party/WebKit/LayoutTests/fast/dom/shadow/getComputedStyle-composed-parent-dirty.html File third_party/WebKit/LayoutTests/fast/dom/shadow/getComputedStyle-composed-parent-dirty.html (right): https://codereview.chromium.org/1675163002/diff/40001/third_party/WebKit/LayoutTests/fast/dom/shadow/getComputedStyle-composed-parent-dirty.html#newcode1 third_party/WebKit/LayoutTests/fast/dom/shadow/getComputedStyle-composed-parent-dirty.html:1: <!DOCTYPE html> On 2016/02/08 06:42:30, tkent wrote: > Probably ...
4 years, 10 months ago (2016-02-08 07:42:54 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675163002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675163002/40001
4 years, 10 months ago (2016-02-08 07:43:16 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-08 07:50:20 UTC) #30
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 07:51:09 UTC) #32
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5c496adcb1c77856494692e0ea3ca358ba2f0415
Cr-Commit-Position: refs/heads/master@{#374095}

Powered by Google App Engine
This is Rietveld 408576698