Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1674813004: Revert of Improve GLSL integer support (Closed)

Created:
4 years, 10 months ago by dcheng
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@uploat_dratindirect
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Improve GLSL integer support (patchset #1 id:1 of https://codereview.chromium.org/1669853002/ ) Reason for revert: MSAN bots are unhappy with this change: https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20MSan%20Tests/builds/7068 Original issue's description: > Improve GLSL integer support > > - Adds shader types for uint. > - Adds a cap for integer support. > - Uses glVertexAttribIPointer for integer attribs. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1669853002 > > Committed: https://skia.googlesource.com/skia/+/3a2caf8ecf38124f4ad21a0f6c4dabfcfa17911a TBR=bsalomon@google.com,egdaniel@google.com,ethannicholas@google.com,cdalton@nvidia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/c4d196c9c87f226eb33b8091dc50053c45c4e752

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -149 lines) Patch
M include/gpu/GrCaps.h View 2 chunks +0 lines, -2 lines 0 comments Download
M include/gpu/GrTypesPriv.h View 13 chunks +10 lines, -42 lines 0 comments Download
M include/gpu/gl/GrGLFunctions.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrCaps.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLAssembleInterface.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLCreateNullInterface.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGLNoOpInterface.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLNoOpInterface.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGLVertexArray.h View 3 chunks +41 lines, -8 lines 0 comments Download
M src/gpu/gl/GrGLVertexArray.cpp View 2 chunks +14 lines, -46 lines 0 comments Download
M src/gpu/gl/SkNullGLContext.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/debug/GrGLCreateDebugInterface.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/glsl/GrGLSL.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (3 generated)
dcheng
Created Revert of Improve GLSL integer support
4 years, 10 months ago (2016-02-06 16:41:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674813004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674813004/1
4 years, 10 months ago (2016-02-06 16:41:27 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 10 months ago (2016-02-06 16:41:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674813004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674813004/1
4 years, 10 months ago (2016-02-06 17:00:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674813004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674813004/1
4 years, 10 months ago (2016-02-06 17:32:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674813004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674813004/1
4 years, 10 months ago (2016-02-06 18:00:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674813004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674813004/1
4 years, 10 months ago (2016-02-06 18:31:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674813004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674813004/1
4 years, 10 months ago (2016-02-06 19:00:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674813004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674813004/1
4 years, 10 months ago (2016-02-06 19:31:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674813004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674813004/1
4 years, 10 months ago (2016-02-06 20:01:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674813004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674813004/1
4 years, 10 months ago (2016-02-06 20:31:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674813004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674813004/1
4 years, 10 months ago (2016-02-06 21:00:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674813004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674813004/1
4 years, 10 months ago (2016-02-06 21:30:52 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674813004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674813004/1
4 years, 10 months ago (2016-02-06 22:00:53 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674813004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674813004/1
4 years, 10 months ago (2016-02-06 22:30:52 UTC) #15
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
4 years, 10 months ago (2016-02-06 22:41:03 UTC) #17
bsalomon
lgtm
4 years, 10 months ago (2016-02-06 23:08:27 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674813004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674813004/1
4 years, 10 months ago (2016-02-06 23:08:45 UTC) #20
commit-bot: I haz the power
4 years, 10 months ago (2016-02-06 23:08:59 UTC) #22
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c4d196c9c87f226eb33b8091dc50053c45c4e752

Powered by Google App Engine
This is Rietveld 408576698