Bind GrContext to GLES2Interface rather than C GLES interface

Bind GrContext to GLES2Interface rather than C GLES interface

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

BUG=442811
Committed: https://crrev.com/4b02c26d9d1b2b1a22d9257bded03f0d03a7a898
Cr-Commit-Position: refs/heads/master@{#382393}

[bsalomon, 2016-02-05 23:03:00]

Description was changed from

==========
WIP, make GrContext bind to WGC3D rather than C GLES interface
==========

to

==========
WIP/hack, make GrContext bind to WGC3D rather than C GLES interface
==========

[bsalomon, 2016-02-06 05:14:30]

Description was changed from

==========
WIP/hack, make GrContext bind to WGC3D rather than C GLES interface
==========

to

==========
WIP/hack, make GrContext bind to WGC3D rather than C GLES interface
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[bsalomon, 2016-02-06 05:34:22]

Description was changed from

==========
WIP/hack, make GrContext bind to WGC3D rather than C GLES interface
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Bind GrContext to GLES2Interface rather than C GLES interface

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[bsalomon, 2016-02-08 02:49:15]

Description was changed from

==========
Bind GrContext to GLES2Interface rather than C GLES interface

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Bind GrContext to GLES2Interface rather than C GLES interface

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

BUG=442811
==========

[bsalomon, 2016-02-08 02:49:59]

bsalomon@google.com changed reviewers:
+ piman@chromium.org, vmiura@chromium.org

[bsalomon, 2016-02-08 02:50:00]

With https://codereview.chromium.org/1674823002/ patched into Skia this works
(at least on Linux).

[piman, 2016-02-08 16:46:41]

Conceptually, this is great.

The only thing is that std::function is not yet allowed in chromium code - it's
still in the to-be-discussed list in
https://chromium-cpp.appspot.com/#library-review . Among others, one of the
questions is whether or not it works on all our compilers (it may be easier now
that we switched to MSVS 2015).
Typically we'd use base::Bind here, but that's probably not an option for skia,
so fwiw I'm supportive of using std::function. Do you want to champion the
addition on cxx@chromium.org?

[bsalomon, 2016-02-08 18:20:27]

On 2016/02/08 16:46:41, piman wrote:
> Conceptually, this is great.
> 
> The only thing is that std::function is not yet allowed in chromium code -
it's
> still in the to-be-discussed list in
> https://chromium-cpp.appspot.com/#library-review . Among others, one of the
> questions is whether or not it works on all our compilers (it may be easier
now
> that we switched to MSVS 2015).
> Typically we'd use base::Bind here, but that's probably not an option for
skia,
> so fwiw I'm supportive of using std::function. Do you want to champion the
> addition on mailto:cxx@chromium.org?

Sure, I will do so. Skia has been using std::function internally for some time
so I imagine Chromium's compilers must all have at least some support for it.

[piman, 2016-03-18 16:42:06]

LGTM, it looks like there was enough consensus on the mailing list to allow this
pattern.

[piman, 2016-03-18 16:42:32]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 16:42:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1671283002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1671283002/120001

[commit-bot: I haz the power, 2016-03-18 16:46:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 16:46:57]

Dry run: Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/8...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bsalomon, 2016-03-19 13:16:19]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-19 13:16:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1671283002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1671283002/140001

[commit-bot: I haz the power, 2016-03-19 14:18:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-19 14:18:33]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2016-03-19 14:25:35]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-03-19 14:25:35]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1671283002/#ps140001
(title: "Fix dependency in gyp and gn?")

[commit-bot: I haz the power, 2016-03-19 14:25:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1671283002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1671283002/140001

[commit-bot: I haz the power, 2016-03-19 14:37:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-19 14:37:05]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[bsalomon, 2016-03-19 14:41:24]

bsalomon@google.com changed reviewers:
+ sgurun@chromium.org, wez@chromium.org

[bsalomon, 2016-03-19 14:41:25]

Adding wez@ and sgurun@ for owner's reviews on webview and blimp

[Wez, 2016-03-19 19:27:28]

blimp/ LGTM

[bsalomon, 2016-03-21 20:05:02]

bsalomon@google.com changed reviewers:
+ boliu@chromium.org

[bsalomon, 2016-03-21 20:05:03]

+@boliu for another webview owner.

[boliu, 2016-03-21 20:09:59]

On 2016/03/21 20:05:03, bsalomon wrote:
> +@boliu for another webview owner.

lgtm

[bsalomon, 2016-03-21 20:19:46]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-03-21 20:20:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1671283002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1671283002/140001

[commit-bot: I haz the power, 2016-03-21 21:21:20]

Description was changed from

==========
Bind GrContext to GLES2Interface rather than C GLES interface

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

BUG=442811
==========

to

==========
Bind GrContext to GLES2Interface rather than C GLES interface

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

BUG=442811
==========

[commit-bot: I haz the power, 2016-03-21 21:21:21]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-03-21 21:22:32]

Description was changed from

==========
Bind GrContext to GLES2Interface rather than C GLES interface

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

BUG=442811
==========

to

==========
Bind GrContext to GLES2Interface rather than C GLES interface

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

BUG=442811

Committed: https://crrev.com/4b02c26d9d1b2b1a22d9257bded03f0d03a7a898
Cr-Commit-Position: refs/heads/master@{#382393}
==========

[commit-bot: I haz the power, 2016-03-21 21:22:33]

Patchset 8 (id:??) landed as
https://crrev.com/4b02c26d9d1b2b1a22d9257bded03f0d03a7a898
Cr-Commit-Position: refs/heads/master@{#382393}