Bind GrContext to GLES2Interfaces in tests

Bind GrContext to GLES2Interfaces in tests

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

[bsalomon, 2016-03-19 21:16:53]

Description was changed from

==========
Bind to GLES2Interfaces in tests

BUG=
==========

to

==========
Bind to GLES2Interfaces in tests

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[bsalomon, 2016-03-19 21:34:55]

bsalomon@google.com changed reviewers:
+ aelias@chromium.org, junov@chromium.org, vmiura@chromium.org

[bsalomon, 2016-03-19 21:34:56]

Ganesh will soon be communicating with the command buffer via GLES2Interface
rather than the C GLES interface. This means that tests can now run directly on
their corresponding GLES2Interface rather than using Ganesh's null GL test
interface. This means exclude its null context from Skia library builds.

I had to bypass hooks in order to upload this and am looking for advice on how
to satisfy checkdeps. I made the gyp/gn changes that are included in patchset 1
to attempt to resolve these errors but it had no effect. Perhaps there is some
layering violation or I should make the gpu_unittest_utils target depend on the
gpu_skia_bindings target? Locally the cc_perftests and webkit_unit_tests targets
build just fine.

Here are the errors I get:

"""
You added one or more #includes that violate checkdeps rules.
  cc/raster/tile_task_worker_pool_perftest.cc
      Illegal include: "gpu/skia_bindings/gl_bindings_skia_cmd_buffer.h"
    Because of no rule applying. \
  third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp
      Illegal include: "gpu/skia_bindings/gl_bindings_skia_cmd_buffer.h"
    Because of no rule applying.
"""

[bsalomon, 2016-03-22 19:38:38]

Description was changed from

==========
Bind to GLES2Interfaces in tests

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Bind to GLES2Interfaces in tests

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[bsalomon, 2016-03-22 19:38:39]

bsalomon@google.com changed reviewers:
+ dalecurtis@chromium.org, piman@chromium.org

[aelias_OOO_until_Jul13, 2016-03-22 20:26:33]

aelias@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[aelias_OOO_until_Jul13, 2016-03-22 20:28:14]

This looks legit to me too and I can't see what's going wrong, I guess there is
some subtlety in DEPS rules that we're missing.  [+phajdan.jr] who wrote
checkdeps.py -- Pawel, could you explain what's wrong with this patch?

[bsalomon, 2016-03-22 20:35:41]

I think I figured it out. I didn't realize that the script was complaining about
DEPS rules. My first patchset didn't modify DEPS at all. I since added some new
include_rules. I added a new DEPS file to cc/raster. I'm not sure if that was
the right thing to do.

[aelias_OOO_until_Jul13, 2016-03-22 20:40:10]

On 2016/03/22 at 20:35:41, bsalomon wrote:
> I think I figured it out. I didn't realize that the script was complaining
about DEPS rules. My first patchset didn't modify DEPS at all. I since added
some new include_rules. I added a new DEPS file to cc/raster. I'm not sure if
that was the right thing to do.

Ah, got it.  Looks fine.  I just looked now at your latest patchset and it
seemed correct, as it indeed is, without realizing you fixed it just an hour ago
:).

[Justin Novosad, 2016-03-22 20:41:30]

platform/graphics lgtm

[DaleCurtis, 2016-03-22 20:43:55]

media/ lgtm assuming cc folk are happy.

[aelias_OOO_until_Jul13, 2016-03-22 20:46:09]

aelias@chromium.org changed reviewers:
- phajdan.jr@chromium.org

[bsalomon, 2016-03-22 20:47:11]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-22 20:47:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1819663002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1819663002/60001

[bsalomon, 2016-03-22 20:49:30]

Description was changed from

==========
Bind to GLES2Interfaces in tests

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Bind GrContext to GLES2Interfaces in tests

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-03-22 20:51:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-22 20:51:48]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[bsalomon, 2016-03-22 20:58:32]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-22 20:58:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1819663002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1819663002/80001

[commit-bot: I haz the power, 2016-03-22 21:10:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-22 21:10:29]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[bsalomon, 2016-03-24 14:32:32]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-24 14:32:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1819663002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1819663002/100001

[commit-bot: I haz the power, 2016-03-24 14:41:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 14:41:25]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[bsalomon, 2016-03-25 14:49:15]

I'm abandoning this in favor of a much simpler CL:
https://codereview.chromium.org/1829363003

The trouble was getting all the mock/test GLES2Interfaces to provide the minimum
viable implementation to make the tests work (e.g. valid limits and providing
non-zero IDs). The other CL let's me remove SkGLContext from the Skialib  but
not the null GrGLInterface. The latter was a lesser goal.