Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: ui/compositor/test/in_process_context_provider.cc

Issue 1671283002: Bind GrContext to GLES2Interface rather than C GLES interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Fix dependency in gyp and gn? Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/skia_bindings/skia_bindings.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/compositor/test/in_process_context_provider.cc
diff --git a/ui/compositor/test/in_process_context_provider.cc b/ui/compositor/test/in_process_context_provider.cc
index 01380345a78562f08a40d96b5c6cd2f6d9f1c0f9..ebf913d55d64511e0a2553b5f72f7e6cf9847b42 100644
--- a/ui/compositor/test/in_process_context_provider.cc
+++ b/ui/compositor/test/in_process_context_provider.cc
@@ -20,24 +20,6 @@
namespace ui {
-namespace {
-
-// Singleton used to initialize and terminate the gles2 library.
-class GLES2Initializer {
- public:
- GLES2Initializer() { gles2::Initialize(); }
-
- ~GLES2Initializer() { gles2::Terminate(); }
-
- private:
- DISALLOW_COPY_AND_ASSIGN(GLES2Initializer);
-};
-
-base::LazyInstance<GLES2Initializer> g_gles2_initializer =
- LAZY_INSTANCE_INITIALIZER;
-
-} // namespace
-
// static
scoped_refptr<InProcessContextProvider> InProcessContextProvider::Create(
const gpu::gles2::ContextCreationAttribHelper& attribs,
@@ -144,28 +126,14 @@ gpu::ContextSupport* InProcessContextProvider::ContextSupport() {
return context_->GetImplementation();
}
-static void BindGrContextCallback(const GrGLInterface* interface) {
- cc::ContextProvider* context_provider =
- reinterpret_cast<InProcessContextProvider*>(interface->fCallbackData);
-
- gles2::SetGLContext(context_provider->ContextGL());
-}
-
class GrContext* InProcessContextProvider::GrContext() {
DCHECK(context_thread_checker_.CalledOnValidThread());
if (gr_context_)
return gr_context_.get();
- // The GrGLInterface factory will make GL calls using the C GLES2 interface.
- // Make sure the gles2 library is initialized first on exactly one thread.
- g_gles2_initializer.Get();
- gles2::SetGLContext(ContextGL());
-
skia::RefPtr<GrGLInterface> interface = skia::AdoptRef(new GrGLInterface);
- skia_bindings::InitCommandBufferSkiaGLBinding(interface.get());
- interface->fCallback = BindGrContextCallback;
- interface->fCallbackData = reinterpret_cast<GrGLInterfaceCallbackData>(this);
+ skia_bindings::InitGLES2InterfaceBindings(interface.get(), ContextGL());
gr_context_ = skia::AdoptRef(GrContext::Create(
kOpenGL_GrBackend, reinterpret_cast<GrBackendContext>(interface.get())));
« no previous file with comments | « gpu/skia_bindings/skia_bindings.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698