Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1670883002: [iOS] Preserve global symbols when calling strip (-x) on today extensions. (Closed)

Created:
4 years, 10 months ago by justincohen
Modified:
4 years, 10 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

[iOS] Preserve global symbols when calling strip (-x) on today extensions. BUG=577711 R=thakis@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/7ab6f482e87a418b4ed5fe68247a93c952af5208

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M pylib/gyp/xcode_emulation.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M test/ios/extension/extension.gyp View 1 2 chunks +8 lines, -2 lines 0 comments Download
M test/ios/gyptest-extension.py View 1 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
justincohen
Is this worth testing for? I'm not sure of an easy way how.
4 years, 10 months ago (2016-02-05 01:30:20 UTC) #2
Nico
maybe something like tools/gyp/test/mac/gyptest-strip.py or tools/gyp/test/mac/gyptest-strip-default.py might work? https://codereview.chromium.org/1670883002/diff/1/pylib/gyp/xcode_emulation.py File pylib/gyp/xcode_emulation.py (right): https://codereview.chromium.org/1670883002/diff/1/pylib/gyp/xcode_emulation.py#newcode942 pylib/gyp/xcode_emulation.py:942: self._IsIosAppExtension(): ...
4 years, 10 months ago (2016-02-05 01:43:00 UTC) #3
justincohen
App extensions are not loadable modules, but I updated the if logic to make it ...
4 years, 10 months ago (2016-02-05 17:20:45 UTC) #4
Nico
lgtm! (since you're enabling the test, please check that it works on the bots -- ...
4 years, 10 months ago (2016-02-05 17:55:27 UTC) #6
justincohen
4 years, 10 months ago (2016-02-05 21:10:54 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
7ab6f482e87a418b4ed5fe68247a93c952af5208 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698