Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Unified Diff: test/ios/gyptest-extension.py

Issue 1670883002: [iOS] Preserve global symbols when calling strip (-x) on today extensions. (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Add test Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/ios/extension/extension.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/ios/gyptest-extension.py
diff --git a/test/ios/gyptest-extension.py b/test/ios/gyptest-extension.py
index 81c019c05e6664f0e05c65b292c79647743d12b0..5bfc62b083164bf60ab159fa99e8abcf5f4b4529 100755
--- a/test/ios/gyptest-extension.py
+++ b/test/ios/gyptest-extension.py
@@ -10,11 +10,15 @@ Verifies that ios app extensions are built correctly.
import TestGyp
import TestMac
+import subprocess
+
+def CheckStrip(p, n_expected):
+ if "ActionViewController" not in subprocess.check_output(['nm','-gU', p]):
+ print "ActionViewController shouldn't get stripped out."
+ test.fail_test()
import sys
if sys.platform == 'darwin' and TestMac.Xcode.Version()>="0600":
- print "This test is currently disabled: https://crbug.com/483696."
- sys.exit(0)
test = TestGyp.TestGyp(formats=['ninja', 'xcode'])
@@ -27,5 +31,10 @@ if sys.platform == 'darwin' and TestMac.Xcode.Version()>="0600":
'ExtensionContainer.app/PlugIns/ActionExtension.appex',
chdir='extension')
+ path = test.built_file_path(
+ 'ExtensionContainer.app/PlugIns/ActionExtension.appex/ActionExtension',
+ chdir='extension')
+ CheckStrip(path, "ActionViewController")
+
test.pass_test()
« no previous file with comments | « test/ios/extension/extension.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698