pylib/gyp/xcode_emulation.py - Issue 1670883002: [iOS] Preserve global symbols when calling strip (-x) on today extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/xcode_emulation.py

Issue 1670883002: [iOS] Preserve global symbols when calling strip (-x) on today extensions. (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Add test Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pylib/gyp/xcode_emulation.py

diff --git a/pylib/gyp/xcode_emulation.py b/pylib/gyp/xcode_emulation.py

index 865940290751ac6087be8a8252c6120d56ac7417..f5a35e437853261755662db7d97f10cecc9cf593 100644

--- a/pylib/gyp/xcode_emulation.py

+++ b/pylib/gyp/xcode_emulation.py

@@ -938,7 +938,8 @@ class XcodeSettings(object):

self._Test('STRIP_INSTALLED_PRODUCT', 'YES', default='NO')):

default_strip_style = 'debugging'

- if self.spec['type'] == 'loadable_module' and self._IsBundle():

+ if ((self.spec['type'] == 'loadable_module' or self._IsIosAppExtension())

+ and self._IsBundle()):

default_strip_style = 'non-global'

elif self.spec['type'] == 'executable':

default_strip_style = 'all'

« no previous file with comments | « no previous file | test/ios/extension/extension.gyp » ('j') | no next file with comments »