Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: pylib/gyp/xcode_emulation.py

Issue 1670883002: [iOS] Preserve global symbols when calling strip (-x) on today extensions. (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 Google Inc. All rights reserved. 1 # Copyright (c) 2012 Google Inc. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """ 5 """
6 This module contains classes that help to emulate xcodebuild behavior on top of 6 This module contains classes that help to emulate xcodebuild behavior on top of
7 other build systems, such as make and ninja. 7 other build systems, such as make and ninja.
8 """ 8 """
9 9
10 import copy 10 import copy
(...skipping 920 matching lines...) Expand 10 before | Expand all | Expand 10 after
931 """Returns a list of shell commands that contain the shell commands 931 """Returns a list of shell commands that contain the shell commands
932 neccessary to strip this target's binary. These should be run as postbuilds 932 neccessary to strip this target's binary. These should be run as postbuilds
933 before the actual postbuilds run.""" 933 before the actual postbuilds run."""
934 self.configname = configname 934 self.configname = configname
935 935
936 result = [] 936 result = []
937 if (self._Test('DEPLOYMENT_POSTPROCESSING', 'YES', default='NO') and 937 if (self._Test('DEPLOYMENT_POSTPROCESSING', 'YES', default='NO') and
938 self._Test('STRIP_INSTALLED_PRODUCT', 'YES', default='NO')): 938 self._Test('STRIP_INSTALLED_PRODUCT', 'YES', default='NO')):
939 939
940 default_strip_style = 'debugging' 940 default_strip_style = 'debugging'
941 if self.spec['type'] == 'loadable_module' and self._IsBundle(): 941 if self.spec['type'] == 'loadable_module' and self._IsBundle() or
942 self._IsIosAppExtension():
Nico 2016/02/05 01:43:00 Hm, are app extensions not of type loadable_module
942 default_strip_style = 'non-global' 943 default_strip_style = 'non-global'
943 elif self.spec['type'] == 'executable': 944 elif self.spec['type'] == 'executable':
944 default_strip_style = 'all' 945 default_strip_style = 'all'
945 946
946 strip_style = self._Settings().get('STRIP_STYLE', default_strip_style) 947 strip_style = self._Settings().get('STRIP_STYLE', default_strip_style)
947 strip_flags = { 948 strip_flags = {
948 'all': '', 949 'all': '',
949 'non-global': '-x', 950 'non-global': '-x',
950 'debugging': '-S', 951 'debugging': '-S',
951 }[strip_style] 952 }[strip_style]
(...skipping 689 matching lines...) Expand 10 before | Expand all | Expand 10 after
1641 if toolset == 'target': 1642 if toolset == 'target':
1642 iphoneos_config_dict['xcode_settings']['SDKROOT'] = 'iphoneos' 1643 iphoneos_config_dict['xcode_settings']['SDKROOT'] = 'iphoneos'
1643 return targets 1644 return targets
1644 1645
1645 def CloneConfigurationForDeviceAndEmulator(target_dicts): 1646 def CloneConfigurationForDeviceAndEmulator(target_dicts):
1646 """If |target_dicts| contains any iOS targets, automatically create -iphoneos 1647 """If |target_dicts| contains any iOS targets, automatically create -iphoneos
1647 targets for iOS device builds.""" 1648 targets for iOS device builds."""
1648 if _HasIOSTarget(target_dicts): 1649 if _HasIOSTarget(target_dicts):
1649 return _AddIOSDeviceConfigurations(target_dicts) 1650 return _AddIOSDeviceConfigurations(target_dicts)
1650 return target_dicts 1651 return target_dicts
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698