Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1670813003: DevTools: do not use platform/ to load injected scripts into inspector/v8. (Closed)

Created:
4 years, 10 months ago by pfeldman
Modified:
4 years, 10 months ago
CC:
chromium-reviews, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, darin-cc_chromium.org, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, blink-reviews-api_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: do not use platform/ to load injected scripts into inspector/v8. BUG=580337 R=dgozman@chromium.org TBR=jochen for stray gyp files. NOTRY=true (linux_android_rel_ng was sick) Committed: https://chromium.googlesource.com/chromium/src/+/4e83aa87a9f10840eefcb6c0bd66d0ff9e7e7002

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : test rebaselined #

Patch Set 4 : updated the chromevox script #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -344 lines) Patch
M chrome/browser/resources/chromeos/chromevox/chromevox.gni View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/tools/jsbundler.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/blink_resource_constants.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/child/blink_platform_impl.cc View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/command-line-api-getEventListeners-expected.txt View 1 2 9 chunks +10 lines, -10 lines 0 comments Download
D third_party/WebKit/Source/build/scripts/rjsmin.py View 1 1 chunk +0 lines, -295 lines 0 comments Download
M third_party/WebKit/Source/core/BUILD.gn View 1 4 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/core.gyp View 1 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 3 2 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/core_generated.gypi View 1 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/inspector/v8/BUILD.gn View 1 1 chunk +43 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/InjectedScriptManager.cpp View 1 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerImpl.cpp View 1 3 chunks +3 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/core/inspector/v8/build/rjsmin.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/Source/core/inspector/v8/build/xxd.py View 1 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/inspector/v8/v8_inspector.gyp View 1 1 chunk +57 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/concatenate_application_code.py View 1 1 chunk +0 lines, -7 lines 0 comments Download
A + third_party/WebKit/Source/devtools/scripts/rjsmin.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/public/blink_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 61 (36 generated)
pfeldman
Partially reverting https://codereview.chromium.org/402033002 for that.
4 years, 10 months ago (2016-02-05 02:18:11 UTC) #2
dgozman
lgtm https://codereview.chromium.org/1670813003/diff/1/third_party/WebKit/Source/core/inspector/v8/V8DebuggerImpl.cpp File third_party/WebKit/Source/core/inspector/v8/V8DebuggerImpl.cpp (right): https://codereview.chromium.org/1670813003/diff/1/third_party/WebKit/Source/core/inspector/v8/V8DebuggerImpl.cpp#newcode723 third_party/WebKit/Source/core/inspector/v8/V8DebuggerImpl.cpp:723: v8::Local<v8::String> scriptValue = v8::String::NewFromUtf8(m_isolate, reinterpret_cast<const char*>(DebuggerScript_js), v8::NewStringType::kInternalized, sizeof(DebuggerScript_js)).ToLocalChecked(); ...
4 years, 10 months ago (2016-02-05 02:49:11 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1670813003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1670813003/20001
4 years, 10 months ago (2016-02-05 03:03:28 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/62400)
4 years, 10 months ago (2016-02-05 03:07:37 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1670813003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1670813003/40001
4 years, 10 months ago (2016-02-06 07:19:06 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/112584) linux_chromium_compile_dbg_ng on ...
4 years, 10 months ago (2016-02-06 07:22:30 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1670813003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1670813003/60001
4 years, 10 months ago (2016-02-06 07:34:07 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/46736)
4 years, 10 months ago (2016-02-06 07:46:32 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1670813003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1670813003/80001
4 years, 10 months ago (2016-02-06 08:14:00 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/170364)
4 years, 10 months ago (2016-02-06 09:28:49 UTC) #24
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1670813003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1670813003/100001
4 years, 10 months ago (2016-02-06 15:36:41 UTC) #26
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-06 17:21:40 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1670813003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1670813003/100001
4 years, 10 months ago (2016-02-06 21:40:20 UTC) #33
commit-bot: I haz the power
Committed patchset #3 (id:100001)
4 years, 10 months ago (2016-02-07 04:29:49 UTC) #35
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/adce7da2534641a5385eabd8f25e9379e4f3ab27 Cr-Commit-Position: refs/heads/master@{#374046}
4 years, 10 months ago (2016-02-07 04:31:43 UTC) #37
Nico
A revert of this CL (patchset #3 id:100001) has been created in https://codereview.chromium.org/1676093002/ by thakis@chromium.org. ...
4 years, 10 months ago (2016-02-07 15:22:05 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1670813003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1670813003/120001
4 years, 10 months ago (2016-02-08 18:05:58 UTC) #42
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/19835)
4 years, 10 months ago (2016-02-08 21:18:54 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1670813003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1670813003/120001
4 years, 10 months ago (2016-02-08 21:42:31 UTC) #46
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1670813003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1670813003/120001
4 years, 10 months ago (2016-02-08 22:24:38 UTC) #50
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
4 years, 10 months ago (2016-02-08 22:41:53 UTC) #52
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1670813003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1670813003/120001
4 years, 10 months ago (2016-02-08 23:04:27 UTC) #55
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
4 years, 10 months ago (2016-02-08 23:15:17 UTC) #57
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/4e83aa87a9f10840eefcb6c0bd66d0ff9e7e7002 Cr-Commit-Position: refs/heads/master@{#374217}
4 years, 10 months ago (2016-02-08 23:36:35 UTC) #59
pfeldman
4 years, 10 months ago (2016-02-08 23:37:06 UTC) #61
Message was sent while issue was closed.
Committed patchset #4 (id:120001) manually as
4e83aa87a9f10840eefcb6c0bd66d0ff9e7e7002 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698