Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1676093002: Revert of DevTools: do not use platform/ to load injected scripts into inspector/v8. (Closed)

Created:
4 years, 10 months ago by Nico
Modified:
4 years, 10 months ago
CC:
chromium-reviews, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, darin-cc_chromium.org, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, blink-reviews-api_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: do not use platform/ to load injected scripts into inspector/v8. (patchset #3 id:100001 of https://codereview.chromium.org/1670813003/ ) Reason for revert: broke https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/14241/steps/generate_build_files/logs/stdio : GYP_DEFINES='branding=Chrome buildtype=Official use_goma=1 gomadir=/b/build/goma chromeos=1' python build/gyp_chromium -G output_dir=out -> returned 1 Updating projects from gyp files... Traceback (most recent call last): File "tools/jsbundler.py", line 48, in <module> import rjsmin ImportError: No module named rjsmin gyp: Call to 'python tools/jsbundler.py -r . -r . -r ../../../../../chrome/third_party/chromevox/third_party/closure-library/closure/goog -x testing -x _test.js chromevox/injected/loader.js' returned exit status 1 while in /b/build/slave/google-chrome-rel-chromeos/build/src/chrome/browser/resources/chromeos/chromevox/chromevox.gyp. step returned non-zero exit code: 1 (also on https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Full https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20(dbg) ) Original issue's description: > DevTools: do not use platform/ to load injected scripts into inspector/v8. > > BUG=580337 > TBR=jochen for stray gyp files. > > Committed: https://crrev.com/adce7da2534641a5385eabd8f25e9379e4f3ab27 > Cr-Commit-Position: refs/heads/master@{#374046} TBR=dgozman@chromium.org,jochen@chromium.org,pfeldman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=580337 Committed: https://crrev.com/174c40c5e9028d60c65e6dd24f5965242145fae5 Cr-Commit-Position: refs/heads/master@{#374050}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+345 lines, -762 lines) Patch
M chrome/browser/resources/chromeos/chromevox/chromevox.gni View 1 chunk +1 line, -2 lines 0 comments Download
M components/html_viewer/blink_resource_constants.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/child/blink_platform_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/command-line-api-getEventListeners-expected.txt View 9 chunks +10 lines, -10 lines 0 comments Download
A third_party/WebKit/Source/build/scripts/rjsmin.py View 1 chunk +295 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/BUILD.gn View 4 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/core.gyp View 3 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 2 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/core_generated.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/v8/BUILD.gn View 1 chunk +0 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/InjectedScriptManager.cpp View 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerImpl.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/v8/build/rjsmin.py View 1 chunk +0 lines, -295 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/v8/build/xxd.py View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/v8/v8_inspector.gyp View 1 chunk +0 lines, -57 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/concatenate_application_code.py View 1 chunk +7 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/rjsmin.py View 1 chunk +0 lines, -295 lines 0 comments Download
M third_party/WebKit/public/blink_resources.grd View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Nico
Created Revert of DevTools: do not use platform/ to load injected scripts into inspector/v8.
4 years, 10 months ago (2016-02-07 15:22:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1676093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1676093002/1
4 years, 10 months ago (2016-02-07 15:22:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-07 15:23:07 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-07 15:24:45 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/174c40c5e9028d60c65e6dd24f5965242145fae5
Cr-Commit-Position: refs/heads/master@{#374050}

Powered by Google App Engine
This is Rietveld 408576698