Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 402033002: Migrate all usages of xxd.py to blink_resources.grd and remove xxd.py - Part 3 (Closed)

Created:
6 years, 5 months ago by vivekg_samsung
Modified:
6 years, 5 months ago
CC:
blink-reviews, vsevik+blink_chromium.org, caseq+blink_chromium.org, arv+blink, jamesr, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, loislo+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Migrate all usages of xxd.py to blink_resources.grd and remove xxd.py - Part 3 Blink should make use of blink_resources.grd for the inline resources of inspector. This removes the dependency upon using xxd.py which embeds these resources as strings. Part 1: https://crrev.com/401233003 Part 2: https://crrev.com/403273003 BUG=312586 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178892

Patch Set 1 : #

Patch Set 2 : Patch for landing! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -238 lines) Patch
M Source/bindings/core/v8/ScriptDebugServer.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
D Source/build/ConvertFileToHeaderWithCharacterArray.gypi View 1 chunk +0 lines, -63 lines 0 comments Download
D Source/build/convert_file_to_header_with_character_array.gni View 1 1 chunk +0 lines, -28 lines 0 comments Download
D Source/build/scripts/xxd.py View 1 chunk +0 lines, -50 lines 0 comments Download
M Source/core/BUILD.gn View 1 3 chunks +0 lines, -12 lines 0 comments Download
M Source/core/core.gyp View 3 chunks +0 lines, -52 lines 0 comments Download
M Source/core/inspector/BUILD.gn View 1 2 chunks +0 lines, -25 lines 0 comments Download
M Source/core/inspector/InjectedScriptCanvasModule.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/inspector/InjectedScriptManager.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorOverlay.cpp View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
vivekg
PTAL, thank you!
6 years, 5 months ago (2014-07-21 09:24:12 UTC) #1
jochen (gone - plz use gerrit)
looks good, but I defer to Pavel (as this is the "meat" of the three ...
6 years, 5 months ago (2014-07-21 11:29:09 UTC) #2
vivekg
Friendly ping!
6 years, 5 months ago (2014-07-22 11:16:25 UTC) #3
pfeldman
lgtm awesome, thanks!
6 years, 5 months ago (2014-07-24 07:53:02 UTC) #4
vivekg
The CQ bit was checked by vivekg@chromium.org
6 years, 5 months ago (2014-07-25 01:15:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/402033002/60001
6 years, 5 months ago (2014-07-25 01:17:04 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-25 02:25:46 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 03:05:13 UTC) #8
Message was sent while issue was closed.
Change committed as 178892

Powered by Google App Engine
This is Rietveld 408576698