Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 167063004: [GCM] Move the manifest key checking logic to gcm.register function (Closed)

Created:
6 years, 10 months ago by jianli
Modified:
6 years, 10 months ago
Reviewers:
Nicolas Zea, fgorski
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

[GCM] Move the manifest key checking logic to gcm.register function We should only require the manifest key for gcm.register. A meaningful error should also be returned. BUG=344027 TEST=tests updated and new test added Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251535

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -5 lines) Patch
M chrome/browser/extensions/api/gcm/gcm_api.cc View 1 4 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/gcm/gcm_apitest.cc View 1 chunk +7 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/api_test/gcm/functions/register_without_key/manifest.json View 1 chunk +3 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/api_test/gcm/functions/register_without_key/register.js View 1 1 chunk +4 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/gcm/functions/send/manifest.json View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/gcm/functions/send_message_data/manifest.json View 1 chunk +0 lines, -1 line 0 comments Download
M google_apis/gcm/gcm_client.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jianli
6 years, 10 months ago (2014-02-14 22:29:25 UTC) #1
fgorski
LGTM, but please address the comments. https://codereview.chromium.org/167063004/diff/1/chrome/test/data/extensions/api_test/gcm/functions/register_without_key/register.js File chrome/test/data/extensions/api_test/gcm/functions/register_without_key/register.js (right): https://codereview.chromium.org/167063004/diff/1/chrome/test/data/extensions/api_test/gcm/functions/register_without_key/register.js#newcode9 chrome/test/data/extensions/api_test/gcm/functions/register_without_key/register.js:9: if (chrome.runtime.lastError) check ...
6 years, 10 months ago (2014-02-14 22:34:28 UTC) #2
jianli
https://codereview.chromium.org/167063004/diff/1/chrome/test/data/extensions/api_test/gcm/functions/register_without_key/register.js File chrome/test/data/extensions/api_test/gcm/functions/register_without_key/register.js (right): https://codereview.chromium.org/167063004/diff/1/chrome/test/data/extensions/api_test/gcm/functions/register_without_key/register.js#newcode9 chrome/test/data/extensions/api_test/gcm/functions/register_without_key/register.js:9: if (chrome.runtime.lastError) On 2014/02/14 22:34:28, Filip Gorski wrote: > ...
6 years, 10 months ago (2014-02-14 22:47:26 UTC) #3
Nicolas Zea
lgtm
6 years, 10 months ago (2014-02-14 23:02:20 UTC) #4
jianli
The CQ bit was checked by jianli@chromium.org
6 years, 10 months ago (2014-02-14 23:05:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/167063004/70001
6 years, 10 months ago (2014-02-14 23:08:04 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-15 05:23:02 UTC) #7
Message was sent while issue was closed. 
Change committed as 251535

Powered by Google App Engine
This is Rietveld 408576698