chrome/test/data/extensions/api_test/gcm/functions/register_without_key/register.js - Issue 167063004: [GCM] Move the manifest key checking logic to gcm.register function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/gcm/functions/register_without_key/register.js

Issue 167063004: [GCM] Move the manifest key checking logic to gcm.register function (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address feedback Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/gcm/functions/register_without_key/manifest.json ('k') | chrome/test/data/extensions/api_test/gcm/functions/send/manifest.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/gcm/functions/register_without_key/register.js

diff --git a/chrome/test/data/extensions/api_test/gcm/functions/register/register.js b/chrome/test/data/extensions/api_test/gcm/functions/register_without_key/register.js

similarity index 66%

copy from chrome/test/data/extensions/api_test/gcm/functions/register/register.js

copy to chrome/test/data/extensions/api_test/gcm/functions/register_without_key/register.js

index e1a20e20d1507eacfda9de53dd07e4e3414b3794..66255eb763af6b61dc5f173662b1892b5b400091 100644

--- a/chrome/test/data/extensions/api_test/gcm/functions/register/register.js

+++ b/chrome/test/data/extensions/api_test/gcm/functions/register_without_key/register.js

@@ -6,7 +6,10 @@ chrome.test.runTests([

function testRegister() {

var senderIds = ["Sender1", "Sender2"];

chrome.gcm.register(senderIds, function(registrationId) {

- chrome.test.succeed();

+ if (chrome.runtime.lastError.message == "Manifest key was missing.")

+ chrome.test.succeed();

+ else

+ chrome.test.fail("gcm.register should fail.");

});

}

]);