chrome/browser/extensions/api/gcm/gcm_apitest.cc - Issue 167063004: [GCM] Move the manifest key checking logic to gcm.register function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/gcm/gcm_apitest.cc

Issue 167063004: [GCM] Move the manifest key checking logic to gcm.register function (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address feedback Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/gcm/gcm_apitest.cc

diff --git a/chrome/browser/extensions/api/gcm/gcm_apitest.cc b/chrome/browser/extensions/api/gcm/gcm_apitest.cc

index cfa637620c4f097789d9bb4f669663ed8c033a0f..41372a1b3ca57e3cc3d9598f48117b00ea2dbfe0 100644

--- a/chrome/browser/extensions/api/gcm/gcm_apitest.cc

+++ b/chrome/browser/extensions/api/gcm/gcm_apitest.cc

@@ -101,6 +101,13 @@ IN_PROC_BROWSER_TEST_F(GcmApiTest, Register) {

sender_ids.end());

}

+IN_PROC_BROWSER_TEST_F(GcmApiTest, RegisterWithoutKey) {

+ if (ShouldSkipTest())

+ return;

+ ASSERT_TRUE(RunExtensionTest("gcm/functions/register_without_key"));

IN_PROC_BROWSER_TEST_F(GcmApiTest, SendValidation) {

if (ShouldSkipTest())

return;