[GCM] Move the manifest key checking logic to gcm.register function

google_apis/gcm/gcm_client.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef GOOGLE_APIS_GCM_GCM_CLIENT_H_
 #define GOOGLE_APIS_GCM_GCM_CLIENT_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 22 matching lines @@
 // Messaging server. This interface is not supposed to be thread-safe.
 class GCM_EXPORT GCMClient {
  public:
   enum Result {
     // Successful operation.
     SUCCESS,
     // Invalid parameter.
     INVALID_PARAMETER,
     // Profile not signed in.
     NOT_SIGNED_IN,
+    // Key was missing in the manifest. The register operation requires a key.
+    MANIFEST_KEY_MISSING,

[fgorski, 2014/02/14 22:34:28]

I am a little sceptical about putting it here, as GCMClient does not know about
manifests.
How abotu calling it CERT_MISSING? and then in API giving the error about
manifest?

[jianli, 2014/02/14 22:47:26]

Done.

     // Previous asynchronous operation is still pending to finish. Certain
     // operation, like register, is only allowed one at a time.
     ASYNC_OPERATION_PENDING,
     // Network socket error.
     NETWORK_ERROR,
     // Problem at the server.
     SERVER_ERROR,
     // Exceeded the specified TTL during message sending.
     TTL_EXCEEDED,
     // Other errors.
@@ skipping 116 matching lines @@
                     const std::string& receiver_id,
                     const OutgoingMessage& message) = 0;
 
   // Returns true if GCM becomes ready.
   virtual bool IsReady() const = 0;
 };
 
 }  // namespace gcm
 
 #endif  // GOOGLE_APIS_GCM_GCM_CLIENT_H_