Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1670223002: Android's stack script: Make --output-dir / CHROMIUM_OUTPUT_DIR mandatory (Closed)

Created:
4 years, 10 months ago by agrieve
Modified:
4 years, 10 months ago
Reviewers:
jbudorick, rmcilroy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@output-dir-stack
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android Make --output-dir mandatory for tombstones and friends Friends: * third_party/android_platform/development/scripts/stack * build/android/asan_symbolize.py Mandatory: Required, unless CHROMIUM_OUTPUT_DIR or CHROMIUM_OUT_DIR are set or when the current working directory is an output directory (contains a build.ninja file) BUG=573345 Committed: https://crrev.com/243a025a6eb1318aa715a05a426eba7ab51eed19 Cr-Commit-Position: refs/heads/master@{#375222}

Patch Set 1 #

Patch Set 2 : tombstones as well #

Patch Set 3 : asan_symbolize #

Patch Set 4 : #

Patch Set 5 : more freom prev cl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -6 lines) Patch
M build/android/asan_symbolize.py View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M build/android/pylib/constants/__init__.py View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download
M build/android/tombstones.py View 1 2 3 4 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/android_platform/development/scripts/stack View 1 2 3 1 chunk +10 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (10 generated)
agrieve
plz review, although won't submit until flags are enabled on bots.
4 years, 10 months ago (2016-02-05 15:32:41 UTC) #3
jbudorick
On 2016/02/05 15:32:41, agrieve wrote: > plz review, although won't submit until flags are enabled ...
4 years, 10 months ago (2016-02-05 15:36:05 UTC) #4
agrieve
4 years, 10 months ago (2016-02-05 20:57:03 UTC) #6
agrieve
rmcilroy@chromium.org: Please review changes in stack
4 years, 10 months ago (2016-02-12 01:19:37 UTC) #8
rmcilroy
lgtm
4 years, 10 months ago (2016-02-12 11:14:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1670223002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1670223002/80001
4 years, 10 months ago (2016-02-12 15:41:18 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/166088)
4 years, 10 months ago (2016-02-12 16:20:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1670223002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1670223002/80001
4 years, 10 months ago (2016-02-12 18:22:38 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 10 months ago (2016-02-12 19:11:10 UTC) #18
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:44:14 UTC) #20
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/243a025a6eb1318aa715a05a426eba7ab51eed19
Cr-Commit-Position: refs/heads/master@{#375222}

Powered by Google App Engine
This is Rietveld 408576698