Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: build/android/tombstones.py

Issue 1670223002: Android's stack script: Make --output-dir / CHROMIUM_OUTPUT_DIR mandatory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@output-dir-stack
Patch Set: more freom prev cl Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/constants/__init__.py ('k') | third_party/android_platform/development/scripts/stack » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/tombstones.py
diff --git a/build/android/tombstones.py b/build/android/tombstones.py
index aa3b95622d5865d45f61bc09542005d323368cbb..d3af2a6b439620bc0370a73af2271c6f360a84fb 100755
--- a/build/android/tombstones.py
+++ b/build/android/tombstones.py
@@ -130,8 +130,9 @@ def _ResolveSymbols(tombstone_data, include_stack, device_abi):
stack_tool = os.path.join(os.path.dirname(__file__), '..', '..',
'third_party', 'android_platform', 'development',
'scripts', 'stack')
- proc = subprocess.Popen([stack_tool, '--arch', arch], stdin=subprocess.PIPE,
- stdout=subprocess.PIPE)
+ cmd = [stack_tool, '--arch', arch, '--output-directory',
+ constants.GetOutDirectory()]
+ proc = subprocess.Popen(cmd, stdin=subprocess.PIPE, stdout=subprocess.PIPE)
output = proc.communicate(input='\n'.join(tombstone_data))[0]
for line in output.split('\n'):
if not include_stack and 'Stack Data:' in line:
@@ -250,6 +251,8 @@ def main():
if options.output_directory:
constants.SetOutputDirectory(options.output_directory)
+ # Do an up-front test that the output directory is known.
+ constants.CheckOutputDirectory()
if options.device:
devices = [device_utils.DeviceUtils(options.device)]
« no previous file with comments | « build/android/pylib/constants/__init__.py ('k') | third_party/android_platform/development/scripts/stack » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698