Android's stack script: Make --output-dir / CHROMIUM_OUTPUT_DIR mandatory

build/android/tombstones.py

 #!/usr/bin/env python
 #
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 #
 # Find the most recent tombstone file(s) on all connected devices
 # and prints their stacks.
 #
 # Assumes tombstone file was created with current symbols.
@@ skipping 112 matching lines @@
     found_abi = re.search('ABI: \'(.+?)\'', line)
     if found_abi:
       device_abi = found_abi.group(1)
   arch = _DeviceAbiToArch(device_abi)
   if not arch:
     return
 
   stack_tool = os.path.join(os.path.dirname(__file__), '..', '..',
                             'third_party', 'android_platform', 'development',
                             'scripts', 'stack')
-  proc = subprocess.Popen([stack_tool, '--arch', arch], stdin=subprocess.PIPE,
-                          stdout=subprocess.PIPE)
+  cmd = [stack_tool, '--arch', arch, '--output-directory',
+         constants.GetOutDirectory()]
+  proc = subprocess.Popen(cmd, stdin=subprocess.PIPE, stdout=subprocess.PIPE)
   output = proc.communicate(input='\n'.join(tombstone_data))[0]
   for line in output.split('\n'):
     if not include_stack and 'Stack Data:' in line:
       break
     yield line
 
 
 def _ResolveTombstone(tombstone):
   lines = []
   lines += [tombstone['file'] + ' created on ' + str(tombstone['time']) +
@@ skipping 98 matching lines @@
   options, _ = parser.parse_args()
 
   devil_chromium.Initialize()
 
   blacklist = (device_blacklist.Blacklist(options.blacklist_file)
                if options.blacklist_file
                else None)
 
   if options.output_directory:
     constants.SetOutputDirectory(options.output_directory)
+  # Do an up-front test that the output directory is known.
+  constants.CheckOutputDirectory()
 
   if options.device:
     devices = [device_utils.DeviceUtils(options.device)]
   else:
     devices = device_utils.DeviceUtils.HealthyDevices(blacklist)
 
   # This must be done serially because strptime can hit a race condition if
   # used for the first time in a multithreaded environment.
   # http://bugs.python.org/issue7980
   tombstones = []
   for device in devices:
     tombstones += _GetTombstonesForDevice(device, options)
 
   _ResolveTombstones(options.jobs, tombstones)
 
 
 if __name__ == '__main__':
   sys.exit(main())