build/android/asan_symbolize.py - Issue 1670223002: Android's stack script: Make --output-dir / CHROMIUM_OUTPUT_DIR mandatory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/asan_symbolize.py

Issue 1670223002: Android's stack script: Make --output-dir / CHROMIUM_OUTPUT_DIR mandatory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@output-dir-stack

Patch Set: more freom prev cl Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/asan_symbolize.py

diff --git a/build/android/asan_symbolize.py b/build/android/asan_symbolize.py

index 87fce88a6820c2dca2cad25010c432086852faf7..644cd7c0fba41e843fb09a7c729417546d0ea035 100755

--- a/build/android/asan_symbolize.py

+++ b/build/android/asan_symbolize.py

@@ -100,6 +100,8 @@ def main():

if options.output_directory:

constants.SetOutputDirectory(options.output_directory)

+ # Do an up-front test that the output directory is known.

+ constants.CheckOutputDirectory()

if options.logcat:

asan_input = file(options.logcat, 'r')

« no previous file with comments | « no previous file | build/android/pylib/constants/__init__.py » ('j') | no next file with comments »