Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 166923002: Add touch scrolling modes experimental flags (Closed)

Created:
6 years, 10 months ago by tdresser
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Add touch scrolling modes experimental flags In particular, adds --touch-scrolling-mode=absorb-touchmove, and --touch-scrolling-mode=sync-touchmove. Split out of https://codereview.chromium.org/156783006, which was migrated from https://codereview.chromium.org/140253005/ so some review history is there. BUG=328503 TEST=TouchEventQueueTest.SyncTouchMoveDoesntCancelTouchOnScroll, TouchEventQueueTest.TouchAbsorption Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251596

Patch Set 1 #

Patch Set 2 : Rebase. #

Total comments: 4

Patch Set 3 : Nits, and rebase onto the not-yet-landed CL 156783006 #

Patch Set 4 : Fix out of order initializer error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -8 lines) Patch
M content/browser/renderer_host/input/input_router_impl.cc View 1 2 3 chunks +16 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue.h View 1 2 3 chunks +35 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue.cc View 1 2 6 chunks +30 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_event_queue_unittest.cc View 1 2 3 6 chunks +71 lines, -5 lines 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
tdresser
joi@, could you take a look at content/public/common/content_switches.*? Touch scrolling mode specific tests are currently ...
6 years, 10 months ago (2014-02-14 14:58:17 UTC) #1
Jói
//content/public LGTM
6 years, 10 months ago (2014-02-14 15:05:39 UTC) #2
Rick Byers
On 2014/02/14 15:05:39, Jói wrote: > //content/public LGTM It doesn't look like this piece has ...
6 years, 10 months ago (2014-02-14 20:59:02 UTC) #3
jdduke (slow)
lgtm with nits https://codereview.chromium.org/166923002/diff/120001/content/browser/renderer_host/input/input_router_impl.cc File content/browser/renderer_host/input/input_router_impl.cc (right): https://codereview.chromium.org/166923002/diff/120001/content/browser/renderer_host/input/input_router_impl.cc#newcode119 content/browser/renderer_host/input/input_router_impl.cc:119: { Nit: Move brace up a ...
6 years, 10 months ago (2014-02-14 21:17:59 UTC) #4
tdresser
https://codereview.chromium.org/166923002/diff/120001/content/browser/renderer_host/input/input_router_impl.cc File content/browser/renderer_host/input/input_router_impl.cc (right): https://codereview.chromium.org/166923002/diff/120001/content/browser/renderer_host/input/input_router_impl.cc#newcode119 content/browser/renderer_host/input/input_router_impl.cc:119: { On 2014/02/14 21:18:00, jdduke wrote: > Nit: Move ...
6 years, 10 months ago (2014-02-14 21:24:40 UTC) #5
tdresser
The CQ bit was checked by tdresser@chromium.org
6 years, 10 months ago (2014-02-15 13:17:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/166923002/210001
6 years, 10 months ago (2014-02-15 13:17:11 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-15 13:37:14 UTC) #8
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=227615
6 years, 10 months ago (2014-02-15 13:37:14 UTC) #9
tdresser
The CQ bit was checked by tdresser@chromium.org
6 years, 10 months ago (2014-02-15 18:30:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/166923002/550001
6 years, 10 months ago (2014-02-15 18:30:52 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-15 19:03:37 UTC) #12
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) app_list_unittests, base_unittests, browser_tests, content_browsertests, content_unittests, interactive_ui_tests, ...
6 years, 10 months ago (2014-02-15 19:03:38 UTC) #13
tdresser
The CQ bit was checked by tdresser@chromium.org
6 years, 10 months ago (2014-02-15 19:48:07 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/166923002/550001
6 years, 10 months ago (2014-02-15 19:48:19 UTC) #15
commit-bot: I haz the power
6 years, 10 months ago (2014-02-15 21:11:42 UTC) #16
Message was sent while issue was closed.
Change committed as 251596

Powered by Google App Engine
This is Rietveld 408576698