Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: content/browser/renderer_host/input/touch_event_queue_unittest.cc

Issue 166923002: Add touch scrolling modes experimental flags (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix out of order initializer error. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 #include "base/logging.h" 6 #include "base/logging.h"
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "content/browser/renderer_host/input/timeout_monitor.h" 9 #include "content/browser/renderer_host/input/timeout_monitor.h"
10 #include "content/browser/renderer_host/input/touch_event_queue.h" 10 #include "content/browser/renderer_host/input/touch_event_queue.h"
(...skipping 10 matching lines...) Expand all
21 namespace { 21 namespace {
22 const size_t kDefaultTouchTimeoutDelayMs = 10; 22 const size_t kDefaultTouchTimeoutDelayMs = 10;
23 } 23 }
24 24
25 class TouchEventQueueTest : public testing::Test, 25 class TouchEventQueueTest : public testing::Test,
26 public TouchEventQueueClient { 26 public TouchEventQueueClient {
27 public: 27 public:
28 TouchEventQueueTest() 28 TouchEventQueueTest()
29 : sent_event_count_(0), 29 : sent_event_count_(0),
30 acked_event_count_(0), 30 acked_event_count_(0),
31 last_acked_event_state_(INPUT_EVENT_ACK_STATE_UNKNOWN) {} 31 last_acked_event_state_(INPUT_EVENT_ACK_STATE_UNKNOWN),
32 slop_length_dips_(0),
33 touch_scrolling_mode_(TouchEventQueue::TOUCH_SCROLLING_MODE_DEFAULT) {}
32 34
33 virtual ~TouchEventQueueTest() {} 35 virtual ~TouchEventQueueTest() {}
34 36
35 // testing::Test 37 // testing::Test
36 virtual void SetUp() OVERRIDE { 38 virtual void SetUp() OVERRIDE {
37 queue_.reset(new TouchEventQueue(this, 0)); 39 ResetQueueWithParameters(touch_scrolling_mode_, slop_length_dips_);
38 queue_->OnHasTouchEventHandlers(true); 40 }
41
42 virtual void SetTouchScrollingMode(TouchEventQueue::TouchScrollingMode mode) {
43 touch_scrolling_mode_ = mode;
44 ResetQueueWithParameters(touch_scrolling_mode_, slop_length_dips_);
39 } 45 }
40 46
41 virtual void TearDown() OVERRIDE { 47 virtual void TearDown() OVERRIDE {
42 queue_.reset(); 48 queue_.reset();
43 } 49 }
44 50
45 // TouchEventQueueClient 51 // TouchEventQueueClient
46 virtual void SendTouchEventImmediately( 52 virtual void SendTouchEventImmediately(
47 const TouchEventWithLatencyInfo& event) OVERRIDE { 53 const TouchEventWithLatencyInfo& event) OVERRIDE {
48 ++sent_event_count_; 54 ++sent_event_count_;
(...skipping 22 matching lines...) Expand all
71 } 77 }
72 } 78 }
73 79
74 protected: 80 protected:
75 81
76 void SetUpForTimeoutTesting(size_t timeout_delay_ms) { 82 void SetUpForTimeoutTesting(size_t timeout_delay_ms) {
77 queue_->SetAckTimeoutEnabled(true, timeout_delay_ms); 83 queue_->SetAckTimeoutEnabled(true, timeout_delay_ms);
78 } 84 }
79 85
80 void SetUpForTouchMoveSlopTesting(double slop_length_dips) { 86 void SetUpForTouchMoveSlopTesting(double slop_length_dips) {
81 queue_.reset(new TouchEventQueue(this, slop_length_dips)); 87 slop_length_dips_ = slop_length_dips;
82 queue_->OnHasTouchEventHandlers(true); 88 ResetQueueWithParameters(touch_scrolling_mode_, slop_length_dips_);
83 } 89 }
84 90
85 void SendTouchEvent(const WebTouchEvent& event) { 91 void SendTouchEvent(const WebTouchEvent& event) {
86 queue_->QueueEvent(TouchEventWithLatencyInfo(event, ui::LatencyInfo())); 92 queue_->QueueEvent(TouchEventWithLatencyInfo(event, ui::LatencyInfo()));
87 } 93 }
88 94
89 void SendGestureEvent(WebInputEvent::Type type) { 95 void SendGestureEvent(WebInputEvent::Type type) {
90 WebGestureEvent event; 96 WebGestureEvent event;
91 event.type = type; 97 event.type = type;
92 queue_->OnGestureScrollEvent( 98 queue_->OnGestureScrollEvent(
93 GestureEventWithLatencyInfo(event, ui::LatencyInfo())); 99 GestureEventWithLatencyInfo(event, ui::LatencyInfo()));
94 } 100 }
95 101
96 void SendTouchEventAck(InputEventAckState ack_result) { 102 void SendTouchEventAck(InputEventAckState ack_result) {
97 queue_->ProcessTouchAck(ack_result, ui::LatencyInfo()); 103 queue_->ProcessTouchAck(ack_result, ui::LatencyInfo());
98 } 104 }
99 105
100 void SendGestureEventAck(WebInputEvent::Type type, 106 void SendGestureEventAck(WebInputEvent::Type type,
101 InputEventAckState ack_result) { 107 InputEventAckState ack_result) {
102 blink::WebGestureEvent gesture_event; 108 blink::WebGestureEvent gesture_event;
103 gesture_event.type = type; 109 gesture_event.type = type;
104 GestureEventWithLatencyInfo event(gesture_event, ui::LatencyInfo()); 110 GestureEventWithLatencyInfo event(gesture_event, ui::LatencyInfo());
111 queue_->OnGestureEventAck(event, ack_result);
105 } 112 }
106 113
107 void SetFollowupEvent(const WebTouchEvent& event) { 114 void SetFollowupEvent(const WebTouchEvent& event) {
108 followup_touch_event_.reset(new WebTouchEvent(event)); 115 followup_touch_event_.reset(new WebTouchEvent(event));
109 } 116 }
110 117
111 void SetFollowupEvent(const WebGestureEvent& event) { 118 void SetFollowupEvent(const WebGestureEvent& event) {
112 followup_gesture_event_.reset(new WebGestureEvent(event)); 119 followup_gesture_event_.reset(new WebGestureEvent(event));
113 } 120 }
114 121
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 InputEventAckState acked_event_state() const { 192 InputEventAckState acked_event_state() const {
186 return last_acked_event_state_; 193 return last_acked_event_state_;
187 } 194 }
188 195
189 private: 196 private:
190 void SendTouchEvent() { 197 void SendTouchEvent() {
191 SendTouchEvent(touch_event_); 198 SendTouchEvent(touch_event_);
192 touch_event_.ResetPoints(); 199 touch_event_.ResetPoints();
193 } 200 }
194 201
202 void ResetQueueWithParameters(TouchEventQueue::TouchScrollingMode mode,
203 double slop_length_dips) {
204 queue_.reset(new TouchEventQueue(this, mode, slop_length_dips));
205 queue_->OnHasTouchEventHandlers(true);
206 }
207
195 scoped_ptr<TouchEventQueue> queue_; 208 scoped_ptr<TouchEventQueue> queue_;
196 size_t sent_event_count_; 209 size_t sent_event_count_;
197 size_t acked_event_count_; 210 size_t acked_event_count_;
198 WebTouchEvent last_sent_event_; 211 WebTouchEvent last_sent_event_;
199 WebTouchEvent last_acked_event_; 212 WebTouchEvent last_acked_event_;
200 InputEventAckState last_acked_event_state_; 213 InputEventAckState last_acked_event_state_;
201 SyntheticWebTouchEvent touch_event_; 214 SyntheticWebTouchEvent touch_event_;
202 scoped_ptr<WebTouchEvent> followup_touch_event_; 215 scoped_ptr<WebTouchEvent> followup_touch_event_;
203 scoped_ptr<WebGestureEvent> followup_gesture_event_; 216 scoped_ptr<WebGestureEvent> followup_gesture_event_;
204 scoped_ptr<InputEventAckState> sync_ack_result_; 217 scoped_ptr<InputEventAckState> sync_ack_result_;
218 double slop_length_dips_;
219 TouchEventQueue::TouchScrollingMode touch_scrolling_mode_;
205 base::MessageLoopForUI message_loop_; 220 base::MessageLoopForUI message_loop_;
206 }; 221 };
207 222
208 223
209 // Tests that touch-events are queued properly. 224 // Tests that touch-events are queued properly.
210 TEST_F(TouchEventQueueTest, Basic) { 225 TEST_F(TouchEventQueueTest, Basic) {
211 PressTouchPoint(1, 1); 226 PressTouchPoint(1, 1);
212 EXPECT_EQ(1U, queued_event_count()); 227 EXPECT_EQ(1U, queued_event_count());
213 EXPECT_EQ(1U, GetAndResetSentEventCount()); 228 EXPECT_EQ(1U, GetAndResetSentEventCount());
214 229
(...skipping 1179 matching lines...) Expand 10 before | Expand all | Expand 10 after
1394 EXPECT_EQ(1U, GetAndResetAckedEventCount()); 1409 EXPECT_EQ(1U, GetAndResetAckedEventCount());
1395 1410
1396 // TouchMove's should not should be suppressed, even with the original 1411 // TouchMove's should not should be suppressed, even with the original
1397 // unmoved pointer. 1412 // unmoved pointer.
1398 MoveTouchPoint(0, 0, 0); 1413 MoveTouchPoint(0, 0, 0);
1399 EXPECT_EQ(1U, queued_event_count()); 1414 EXPECT_EQ(1U, queued_event_count());
1400 EXPECT_EQ(1U, GetAndResetSentEventCount()); 1415 EXPECT_EQ(1U, GetAndResetSentEventCount());
1401 EXPECT_EQ(0U, GetAndResetAckedEventCount()); 1416 EXPECT_EQ(0U, GetAndResetAckedEventCount());
1402 } 1417 }
1403 1418
1419 TEST_F(TouchEventQueueTest, SyncTouchMoveDoesntCancelTouchOnScroll) {
1420 SetTouchScrollingMode(TouchEventQueue::TOUCH_SCROLLING_MODE_SYNC_TOUCHMOVE);
1421 // Queue a TouchStart.
1422 PressTouchPoint(0, 1);
1423 EXPECT_EQ(1U, GetAndResetSentEventCount());
1424 SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
1425 EXPECT_EQ(1U, GetAndResetAckedEventCount());
1426
1427 MoveTouchPoint(0, 20, 5);
1428 EXPECT_EQ(1U, queued_event_count());
1429 EXPECT_EQ(1U, GetAndResetSentEventCount());
1430
1431 // GestureScrollBegin doesn't insert a synthetic TouchCancel.
1432 WebGestureEvent followup_scroll;
1433 followup_scroll.type = WebInputEvent::GestureScrollBegin;
1434 SetFollowupEvent(followup_scroll);
1435 SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
1436 EXPECT_EQ(0U, GetAndResetSentEventCount());
1437 EXPECT_EQ(1U, GetAndResetAckedEventCount());
1438 EXPECT_EQ(0U, queued_event_count());
1439 }
1440
1441 TEST_F(TouchEventQueueTest, TouchAbsorption) {
1442 SetTouchScrollingMode(
1443 TouchEventQueue::TOUCH_SCROLLING_MODE_ABSORB_TOUCHMOVE);
1444 // Queue a TouchStart.
1445 PressTouchPoint(0, 1);
1446 EXPECT_EQ(1U, GetAndResetSentEventCount());
1447 SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
1448 EXPECT_EQ(1U, GetAndResetAckedEventCount());
1449
1450 for (int i = 0; i < 3; ++i) {
1451 SendGestureEventAck(WebInputEvent::GestureScrollUpdate,
1452 INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
1453
1454 MoveTouchPoint(0, 20, 5);
1455 SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
1456 EXPECT_EQ(0U, queued_event_count());
1457 EXPECT_EQ(1U, GetAndResetSentEventCount());
1458
1459 // Consuming a scroll event prevents the next touch moves from being
1460 // dispatched.
1461 SendGestureEventAck(WebInputEvent::GestureScrollUpdate,
1462 INPUT_EVENT_ACK_STATE_CONSUMED);
1463 MoveTouchPoint(0, 20, 5);
1464 SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
1465 EXPECT_EQ(0U, queued_event_count());
1466 EXPECT_EQ(0U, GetAndResetSentEventCount());
1467 }
1468 }
1469
1404 } // namespace content 1470 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/renderer_host/input/touch_event_queue.cc ('k') | content/public/common/content_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698