Rename apps::ShellWindow to apps::AppWindow

Rename apps::ShellWindow to apps::AppWindow

* Rename ShellWindowRegistry
* Rename ShellWindowGeometryCache
* Rename members like shell_window_ to app_window_
* Rename locals like shell_window to app_window

BUG=343591
TEST=compiles
COLLABORATOR=scheib@chromium.org
TBR=skuhne@chromium.org for chrome/browser/ui/ash/launcher
TBR=thakis@chromium.org for chrome/browser/ui/cocoa
TBR=erg@chromium.org for chrome/browser/ui/gtk
TBR=sky@chromium.org for chrome/test

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251542

[James Cook, 2014-02-14 20:19:04]

scheib, PTAL.  You might want to just look at the files I actually renamed then
spot-check the rest.

Almost all the changes were targeted find-and-replace. The whole thing has been
through "git cl format".  I put a list of all the exact substitutions I did in
the bug.

[James Cook, 2014-02-14 23:17:41]

scheib, I think I've cleaned up most of the rest of the "shell" and "Shell"
references.

This looks pretty clean, especially if you filter out "launcher" items:
git diff --name-only master | xargs grep -i "[^:/_]shell"

[scheib, 2014-02-15 00:02:13]

https://codereview.chromium.org/166573005/diff/180001/apps/app_window_interac...
File apps/app_window_interactive_uitest.cc (right):

https://codereview.chromium.org/166573005/diff/180001/apps/app_window_interac...
apps/app_window_interactive_uitest.cc:16: const char kDefaultTestApp[] =
"shell_window/generic";
I think it is reasonable to leave this as is vs moving the test -- but just
drawing it out to your attention.

https://codereview.chromium.org/166573005/diff/180001/apps/apps.gypi
File apps/apps.gypi (right):

https://codereview.chromium.org/166573005/diff/180001/apps/apps.gypi#newcode57
apps/apps.gypi:57: 'app_window.cc',
sort

[scheib, 2014-02-15 00:12:33]

https://codereview.chromium.org/166573005/diff/180001/chrome/browser/ui/ash/l...
File
chrome/browser/ui/ash/launcher/multi_profile_shell_window_launcher_controller.h
(right):

https://codereview.chromium.org/166573005/diff/180001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/multi_profile_shell_window_launcher_controller.h:12:
// TODO(jamescook): Rename this to MultiProfileAppWindowLauncherController.
issue number?

https://codereview.chromium.org/166573005/diff/180001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/shell_window_launcher_controller.h (right):

https://codereview.chromium.org/166573005/diff/180001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/shell_window_launcher_controller.h:37: //
TODO(jamescook): Rename this to AppWindowLauncherController.
issue number?

https://codereview.chromium.org/166573005/diff/180001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm (right):

https://codereview.chromium.org/166573005/diff/180001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm:178: @interface
ShellNSWindow : ChromeEventProcessingWindow
Perhaps file an issue to clean up the mac NSWindow classes?

[scheib, 2014-02-15 00:26:34]

https://codereview.chromium.org/166573005/diff/180001/chrome/browser/apps/app...
File chrome/browser/apps/app_browsertest.cc (right):

https://codereview.chromium.org/166573005/diff/180001/chrome/browser/apps/app...
chrome/browser/apps/app_browsertest.cc:808: // Runs a test inside a harness that
opens DevTools on a app window.
a -> an app window

https://codereview.chromium.org/166573005/diff/180001/chrome/browser/ui/apps/...
File chrome/browser/ui/apps/chrome_shell_window_delegate.h (right):

https://codereview.chromium.org/166573005/diff/180001/chrome/browser/ui/apps/...
chrome/browser/ui/apps/chrome_shell_window_delegate.h:32: // TODO(jamescook):
Rename to ChromeAppWindowDelegate.
issue

https://codereview.chromium.org/166573005/diff/180001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/shell_window_launcher_item_controller.h
(right):

https://codereview.chromium.org/166573005/diff/180001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/shell_window_launcher_item_controller.h:38: //
TODO(jamescook): Rename to AppWindowLauncherItemController.
issue

[scheib, 2014-02-15 00:30:49]

lgtm with nits mentions previously as optional.

[James Cook, 2014-02-15 01:13:16]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-02-15 01:25:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/166573005/370001

[commit-bot: I haz the power, 2014-02-15 03:27:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-15 03:27:45]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[scheib, 2014-02-15 03:30:38]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2014-02-15 03:30:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/166573005/370001

[commit-bot: I haz the power, 2014-02-15 05:36:41]

Change committed as 251542