Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Unified Diff: apps/app_shim/extension_app_shim_handler_mac_unittest.cc

Issue 166573005: Rename apps::ShellWindow to apps::AppWindow (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase, nits (rename) Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « apps/app_shim/extension_app_shim_handler_mac.cc ('k') | apps/app_window.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: apps/app_shim/extension_app_shim_handler_mac_unittest.cc
diff --git a/apps/app_shim/extension_app_shim_handler_mac_unittest.cc b/apps/app_shim/extension_app_shim_handler_mac_unittest.cc
index 4e528f3cad8d67430508d1aa930983f5f5b7af04..753bd51678902c434db64b78572facbd519a6d1a 100644
--- a/apps/app_shim/extension_app_shim_handler_mac_unittest.cc
+++ b/apps/app_shim/extension_app_shim_handler_mac_unittest.cc
@@ -18,7 +18,7 @@
namespace apps {
using extensions::Extension;
-typedef ShellWindowRegistry::ShellWindowList ShellWindowList;
+typedef AppWindowRegistry::AppWindowList AppWindowList;
using ::testing::_;
using ::testing::Invoke;
@@ -35,7 +35,7 @@ class MockDelegate : public ExtensionAppShimHandler::Delegate {
void(const base::FilePath&,
base::Callback<void(Profile*)>));
- MOCK_METHOD2(GetWindows, ShellWindowList(Profile*, const std::string&));
+ MOCK_METHOD2(GetWindows, AppWindowList(Profile*, const std::string&));
MOCK_METHOD2(GetAppExtension, const Extension*(Profile*, const std::string&));
MOCK_METHOD3(EnableExtension, void(Profile*,
@@ -175,10 +175,10 @@ class ExtensionAppShimHandlerTest : public testing::Test {
// In most tests, we don't care about the result of GetWindows, it just
// needs to be non-empty.
- ShellWindowList shell_window_list;
- shell_window_list.push_back(static_cast<ShellWindow*>(NULL));
+ AppWindowList app_window_list;
+ app_window_list.push_back(static_cast<AppWindow*>(NULL));
EXPECT_CALL(*delegate_, GetWindows(_, _))
- .WillRepeatedly(Return(shell_window_list));
+ .WillRepeatedly(Return(app_window_list));
EXPECT_CALL(*delegate_, GetAppExtension(_, kTestAppIdA))
.WillRepeatedly(Return(extension_a_.get()));
@@ -302,10 +302,10 @@ TEST_F(ExtensionAppShimHandlerTest, AppLifetime) {
RegisterOnlyLaunch(&host_aa_);
EXPECT_EQ(&host_aa_, handler_->FindHost(&profile_a_, kTestAppIdA));
- // Return no shell windows for OnShimFocus and OnShimQuit.
- ShellWindowList shell_window_list;
+ // Return no app windows for OnShimFocus and OnShimQuit.
+ AppWindowList app_window_list;
EXPECT_CALL(*delegate_, GetWindows(&profile_a_, kTestAppIdA))
- .WillRepeatedly(Return(shell_window_list));
+ .WillRepeatedly(Return(app_window_list));
// Non-reopen focus does nothing.
EXPECT_CALL(*handler_, OnShimFocus(&host_aa_, APP_SHIM_FOCUS_NORMAL, _))
@@ -351,9 +351,9 @@ TEST_F(ExtensionAppShimHandlerTest, MaybeTerminate) {
EXPECT_EQ(&host_ab_, handler_->FindHost(&profile_a_, kTestAppIdB));
// Return empty window list.
- ShellWindowList shell_window_list;
+ AppWindowList app_window_list;
EXPECT_CALL(*delegate_, GetWindows(_, _))
- .WillRepeatedly(Return(shell_window_list));
+ .WillRepeatedly(Return(app_window_list));
// Quitting when there's another shim should not terminate.
EXPECT_CALL(*delegate_, MaybeTerminate())
« no previous file with comments | « apps/app_shim/extension_app_shim_handler_mac.cc ('k') | apps/app_window.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698