Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6496)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 166573005: Rename apps::ShellWindow to apps::AppWindow (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase, nits (rename) Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
index 4ff0161028bd811d9156b0fb48a8e768e295c58a..491c188b36c4880ab2014dd21dbef28ce1f88560 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
@@ -6,9 +6,9 @@
#include "apps/app_load_service.h"
#include "apps/app_restore_service.h"
+#include "apps/app_window.h"
+#include "apps/app_window_registry.h"
#include "apps/saved_files_service.h"
-#include "apps/shell_window.h"
-#include "apps/shell_window_registry.h"
#include "base/auto_reset.h"
#include "base/base64.h"
#include "base/bind.h"
@@ -1121,9 +1121,9 @@ ExtensionSettingsHandler::GetInspectablePagesForExtension(
process_manager->GetRenderViewHostsForExtension(extension->id()),
&result);
- // Get shell window views
- GetShellWindowPagesForExtensionProfile(extension,
- extension_service_->profile(), &result);
+ // Get app window views
+ GetAppWindowPagesForExtensionProfile(
+ extension, extension_service_->profile(), &result);
// Include a link to start the lazy background page, if applicable.
if (BackgroundInfo::HasLazyBackgroundPage(extension) &&
@@ -1138,7 +1138,7 @@ ExtensionSettingsHandler::GetInspectablePagesForExtension(
}
// Repeat for the incognito process, if applicable. Don't try to get
- // shell windows for incognito processes.
+ // app windows for incognito processes.
if (extension_service_->profile()->HasOffTheRecordProfile() &&
IncognitoInfo::IsSplitMode(extension) &&
util::IsIncognitoEnabled(extension->id(),
@@ -1195,20 +1195,21 @@ void ExtensionSettingsHandler::GetInspectablePagesForExtensionProcess(
}
}
-void ExtensionSettingsHandler::GetShellWindowPagesForExtensionProfile(
+void ExtensionSettingsHandler::GetAppWindowPagesForExtensionProfile(
const Extension* extension,
Profile* profile,
std::vector<ExtensionPage>* result) {
- apps::ShellWindowRegistry* registry = apps::ShellWindowRegistry::Get(profile);
+ apps::AppWindowRegistry* registry = apps::AppWindowRegistry::Get(profile);
if (!registry) return;
- const apps::ShellWindowRegistry::ShellWindowList windows =
- registry->GetShellWindowsForApp(extension->id());
+ const apps::AppWindowRegistry::AppWindowList windows =
+ registry->GetAppWindowsForApp(extension->id());
bool has_generated_background_page =
BackgroundInfo::HasGeneratedBackgroundPage(extension);
- for (apps::ShellWindowRegistry::const_iterator it = windows.begin();
- it != windows.end(); ++it) {
+ for (apps::AppWindowRegistry::const_iterator it = windows.begin();
+ it != windows.end();
+ ++it) {
WebContents* web_contents = (*it)->web_contents();
RenderViewHost* host = web_contents->GetRenderViewHost();
content::RenderProcessHost* process = host->GetProcess();

Powered by Google App Engine
This is Rietveld 408576698