Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1089)

Unified Diff: chrome/browser/policy/policy_browsertest.cc

Issue 166573005: Rename apps::ShellWindow to apps::AppWindow (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase, nits (rename) Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/policy_browsertest.cc
diff --git a/chrome/browser/policy/policy_browsertest.cc b/chrome/browser/policy/policy_browsertest.cc
index 5d5c6b7b087fa3fecff5c5d62ff83cb2198c5c1c..015b37ff11a5d52f9f9b1ac2799160f609f2a819 100644
--- a/chrome/browser/policy/policy_browsertest.cc
+++ b/chrome/browser/policy/policy_browsertest.cc
@@ -153,8 +153,8 @@
#endif
#if !defined(OS_MACOSX)
-#include "apps/shell_window.h"
-#include "apps/shell_window_registry.h"
+#include "apps/app_window.h"
+#include "apps/app_window_registry.h"
#include "apps/ui/native_app_window.h"
#include "base/basictypes.h"
#include "base/compiler_specific.h"
@@ -534,54 +534,49 @@ void WebContentsLoadedOrDestroyedWatcher::DidStopLoading(
#if !defined(OS_MACOSX)
-// Observer used to wait for the creation of a new shell window.
-class TestAddShellWindowObserver : public apps::ShellWindowRegistry::Observer {
+// Observer used to wait for the creation of a new app window.
+class TestAddAppWindowObserver : public apps::AppWindowRegistry::Observer {
public:
- explicit TestAddShellWindowObserver(apps::ShellWindowRegistry* registry);
- virtual ~TestAddShellWindowObserver();
+ explicit TestAddAppWindowObserver(apps::AppWindowRegistry* registry);
+ virtual ~TestAddAppWindowObserver();
- // apps::ShellWindowRegistry::Observer:
- virtual void OnShellWindowAdded(apps::ShellWindow* shell_window) OVERRIDE;
- virtual void OnShellWindowIconChanged(
- apps::ShellWindow* shell_window) OVERRIDE;
- virtual void OnShellWindowRemoved(apps::ShellWindow* shell_window) OVERRIDE;
+ // apps::AppWindowRegistry::Observer:
+ virtual void OnAppWindowAdded(apps::AppWindow* app_window) OVERRIDE;
+ virtual void OnAppWindowIconChanged(apps::AppWindow* app_window) OVERRIDE;
+ virtual void OnAppWindowRemoved(apps::AppWindow* app_window) OVERRIDE;
- apps::ShellWindow* WaitForShellWindow();
+ apps::AppWindow* WaitForAppWindow();
private:
- apps::ShellWindowRegistry* registry_; // Not owned.
- apps::ShellWindow* window_; // Not owned.
+ apps::AppWindowRegistry* registry_; // Not owned.
+ apps::AppWindow* window_; // Not owned.
base::RunLoop run_loop_;
- DISALLOW_COPY_AND_ASSIGN(TestAddShellWindowObserver);
+ DISALLOW_COPY_AND_ASSIGN(TestAddAppWindowObserver);
};
-TestAddShellWindowObserver::TestAddShellWindowObserver(
- apps::ShellWindowRegistry* registry)
- : registry_(registry),
- window_(NULL) {
+TestAddAppWindowObserver::TestAddAppWindowObserver(
+ apps::AppWindowRegistry* registry)
+ : registry_(registry), window_(NULL) {
registry_->AddObserver(this);
}
-TestAddShellWindowObserver::~TestAddShellWindowObserver() {
+TestAddAppWindowObserver::~TestAddAppWindowObserver() {
registry_->RemoveObserver(this);
}
-void TestAddShellWindowObserver::OnShellWindowAdded(
- apps::ShellWindow* shell_window) {
- window_ = shell_window;
+void TestAddAppWindowObserver::OnAppWindowAdded(apps::AppWindow* app_window) {
+ window_ = app_window;
run_loop_.Quit();
}
-void TestAddShellWindowObserver::OnShellWindowIconChanged(
- apps::ShellWindow* shell_window) {
-}
+void TestAddAppWindowObserver::OnAppWindowIconChanged(
+ apps::AppWindow* app_window) {}
-void TestAddShellWindowObserver::OnShellWindowRemoved(
- apps::ShellWindow* shell_window) {
+void TestAddAppWindowObserver::OnAppWindowRemoved(apps::AppWindow* app_window) {
}
-apps::ShellWindow* TestAddShellWindowObserver::WaitForShellWindow() {
+apps::AppWindow* TestAddAppWindowObserver::WaitForAppWindow() {
run_loop_.Run();
return window_;
}
@@ -2095,13 +2090,13 @@ IN_PROC_BROWSER_TEST_F(PolicyTest, FullscreenAllowedApp) {
ASSERT_TRUE(extension);
// Launch an app that tries to open a fullscreen window.
- TestAddShellWindowObserver add_window_observer(
- apps::ShellWindowRegistry::Get(browser()->profile()));
+ TestAddAppWindowObserver add_window_observer(
+ apps::AppWindowRegistry::Get(browser()->profile()));
OpenApplication(AppLaunchParams(browser()->profile(),
extension,
extensions::LAUNCH_CONTAINER_NONE,
NEW_WINDOW));
- apps::ShellWindow* window = add_window_observer.WaitForShellWindow();
+ apps::AppWindow* window = add_window_observer.WaitForAppWindow();
ASSERT_TRUE(window);
// Verify that the window is not in fullscreen mode.
« no previous file with comments | « chrome/browser/extensions/window_open_apitest.cc ('k') | chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698