Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1665453002: Reland of Update device/usb and its Mojo interface for variable size ISO packets. (Closed)

Created:
4 years, 10 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 10 months ago
Reviewers:
scheib, dgozman, zhaoqin1
CC:
chromium-reviews, extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Update device/usb and its Mojo interface for variable size ISO packets. (patchset #1 id:1 of https://codereview.chromium.org/1658953003/ ) Reason for revert: Fixed the uninitialized test buffer. Original issue's description: > Revert of Update device/usb and its Mojo interface for variable size ISO packets. (patchset #3 id:120001 of https://codereview.chromium.org/1618393004/ ) > > Reason for revert: > Uninit error from UsbApiTest.TransferFailure > > BUG=583343 > > Original issue's description: > > Update device/usb and its Mojo interface for variable size ISO packets. > > > > To support the WebUSB API our underlying USB library needs to support > > isochronous transfers with full control over the packet size. We also > > need to know the completion status of each packet which was previously > > not available. > > > > This patch updates the interface to match that provided by libusb and > > the underlying platform specific APIs. > > > > BUG=492204 > > > > Committed: https://crrev.com/051c98e9d3e843295d659b5676fcfa9dc1be5da6 > > Cr-Commit-Position: refs/heads/master@{#372844} > > TBR=scheib@chromium.org,dgozman@chromium.org,reillyg@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=492204 > > Committed: https://crrev.com/c40c36ef3d3a722e0df920a4bbae25695f0b18e8 > Cr-Commit-Position: refs/heads/master@{#372971} TBR=scheib@chromium.org,dgozman@chromium.org,zhaoqin@chromium.org BUG=583343 Committed: https://crrev.com/ccbaed85d9538dc645535efdb58c0af6ebafdd43 Cr-Commit-Position: refs/heads/master@{#373065}

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+626 lines, -280 lines) Patch
M chrome/browser/devtools/device/usb/android_usb_browsertest.cc View 1 chunk +12 lines, -8 lines 0 comments Download
M device/devices_app/usb/device_impl.h View 3 chunks +6 lines, -6 lines 0 comments Download
M device/devices_app/usb/device_impl.cc View 3 chunks +51 lines, -45 lines 0 comments Download
M device/devices_app/usb/device_impl_unittest.cc View 8 chunks +135 lines, -60 lines 0 comments Download
M device/devices_app/usb/public/interfaces/device.mojom View 3 chunks +24 lines, -13 lines 0 comments Download
M device/devices_app/usb/type_converters.h View 2 chunks +10 lines, -2 lines 0 comments Download
M device/devices_app/usb/type_converters.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M device/usb/mock_usb_device_handle.h View 3 chunks +13 lines, -10 lines 0 comments Download
M device/usb/usb_device_handle.h View 3 chunks +23 lines, -9 lines 0 comments Download
M device/usb/usb_device_handle_impl.h View 2 chunks +22 lines, -13 lines 0 comments Download
M device/usb/usb_device_handle_impl.cc View 14 chunks +158 lines, -82 lines 0 comments Download
M extensions/browser/api/usb/usb_api.h View 3 chunks +6 lines, -2 lines 0 comments Download
M extensions/browser/api/usb/usb_api.cc View 4 chunks +70 lines, -25 lines 0 comments Download
M extensions/browser/api/usb/usb_apitest.cc View 4 chunks +47 lines, -5 lines 1 comment Download
M extensions/test/data/api_test/usb/transfer_event/test.js View 4 chunks +4 lines, -0 lines 0 comments Download
M extensions/test/data/api_test/usb/transfer_failure/test.js View 1 chunk +32 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
Reilly Grant (use Gerrit)
Created Reland of Update device/usb and its Mojo interface for variable size ISO packets.
4 years, 10 months ago (2016-02-02 21:12:21 UTC) #1
Reilly Grant (use Gerrit)
https://codereview.chromium.org/1665453002/diff/270001/extensions/browser/api/usb/usb_apitest.cc File extensions/browser/api/usb/usb_apitest.cc (right): https://codereview.chromium.org/1665453002/diff/270001/extensions/browser/api/usb/usb_apitest.cc#newcode75 extensions/browser/api/usb/usb_apitest.cc:75: memset(io_buffer->data(), 0, total_length); // Avoid uninitialized reads. For the ...
4 years, 10 months ago (2016-02-02 21:14:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1665453002/270001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1665453002/270001
4 years, 10 months ago (2016-02-02 21:16:29 UTC) #6
scheib
Would you re-upload to previous patch so that patch diffs work (fore reviewers and posterity), ...
4 years, 10 months ago (2016-02-02 21:16:59 UTC) #7
scheib
[offline conversation happened] OK, LGTM for this one, easier review next time.
4 years, 10 months ago (2016-02-02 21:21:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:270001)
4 years, 10 months ago (2016-02-02 22:50:41 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 22:51:55 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ccbaed85d9538dc645535efdb58c0af6ebafdd43
Cr-Commit-Position: refs/heads/master@{#373065}

Powered by Google App Engine
This is Rietveld 408576698