Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Issue 1635903004: Add support for isochronous transfers in WebUSB. (Closed)

Created:
4 years, 11 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@usb_isoc
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for isochronous transfers in WebUSB. This change adds support for the newly speced isochronousTransferIn and isochronousTransferOut functions on the USBDevice object. BUG=492204 Committed: https://crrev.com/2ddf523a83030d970cf5868103881adc0f41ae2b Cr-Commit-Position: refs/heads/master@{#373439}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Fix tense. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+443 lines, -43 lines) Patch
M content/renderer/usb/web_usb_device_impl.h View 1 chunk +10 lines, -2 lines 0 comments Download
M content/renderer/usb/web_usb_device_impl.cc View 5 chunks +112 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 chunks +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 1 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBDevice.h View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBDevice.cpp View 4 chunks +61 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBDevice.idl View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/webusb/USBIsochronousInTransferPacket.h View 1 chunk +43 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/modules/webusb/USBIsochronousInTransferPacket.idl View 1 chunk +4 lines, -4 lines 0 comments Download
A third_party/WebKit/Source/modules/webusb/USBIsochronousInTransferResult.h View 1 chunk +48 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/webusb/USBIsochronousInTransferResult.idl View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/webusb/USBIsochronousOutTransferPacket.h View 1 chunk +42 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/modules/webusb/USBIsochronousOutTransferPacket.idl View 1 chunk +4 lines, -4 lines 0 comments Download
A third_party/WebKit/Source/modules/webusb/USBIsochronousOutTransferResult.h View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/webusb/USBIsochronousOutTransferResult.idl View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/modules/webusb/WebUSBDevice.h View 2 chunks +8 lines, -10 lines 0 comments Download
M third_party/WebKit/public/platform/modules/webusb/WebUSBTransferInfo.h View 1 1 chunk +12 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Reilly Grant (use Gerrit)
Please take a look.
4 years, 10 months ago (2016-02-02 22:02:10 UTC) #5
Ken Rockot(use gerrit already)
lgtm https://codereview.chromium.org/1635903004/diff/40001/third_party/WebKit/public/platform/modules/webusb/WebUSBTransferInfo.h File third_party/WebKit/public/platform/modules/webusb/WebUSBTransferInfo.h (right): https://codereview.chromium.org/1635903004/diff/40001/third_party/WebKit/public/platform/modules/webusb/WebUSBTransferInfo.h#newcode23 third_party/WebKit/public/platform/modules/webusb/WebUSBTransferInfo.h:23: // Individual packet statuses. This vector has only ...
4 years, 10 months ago (2016-02-03 14:19:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1635903004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1635903004/60001
4 years, 10 months ago (2016-02-04 01:00:33 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 10 months ago (2016-02-04 02:42:19 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 02:43:08 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2ddf523a83030d970cf5868103881adc0f41ae2b
Cr-Commit-Position: refs/heads/master@{#373439}

Powered by Google App Engine
This is Rietveld 408576698