Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1658953003: Revert of Update device/usb and its Mojo interface for variable size ISO packets. (Closed)

Created:
4 years, 10 months ago by zhaoqin1
Modified:
4 years, 10 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update device/usb and its Mojo interface for variable size ISO packets. (patchset #3 id:120001 of https://codereview.chromium.org/1618393004/ ) Reason for revert: Uninit error from UsbApiTest.TransferFailure BUG=583343 Original issue's description: > Update device/usb and its Mojo interface for variable size ISO packets. > > To support the WebUSB API our underlying USB library needs to support > isochronous transfers with full control over the packet size. We also > need to know the completion status of each packet which was previously > not available. > > This patch updates the interface to match that provided by libusb and > the underlying platform specific APIs. > > BUG=492204 > > Committed: https://crrev.com/051c98e9d3e843295d659b5676fcfa9dc1be5da6 > Cr-Commit-Position: refs/heads/master@{#372844} TBR=scheib@chromium.org,dgozman@chromium.org,reillyg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=492204 Committed: https://crrev.com/c40c36ef3d3a722e0df920a4bbae25695f0b18e8 Cr-Commit-Position: refs/heads/master@{#372971}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+313 lines, -658 lines) Patch
M chrome/browser/devtools/device/usb/android_usb_browsertest.cc View 1 chunk +8 lines, -12 lines 0 comments Download
M device/devices_app/usb/device_impl.h View 3 chunks +6 lines, -6 lines 0 comments Download
M device/devices_app/usb/device_impl.cc View 3 chunks +47 lines, -53 lines 0 comments Download
M device/devices_app/usb/device_impl_unittest.cc View 8 chunks +67 lines, -142 lines 0 comments Download
M device/devices_app/usb/public/interfaces/device.mojom View 3 chunks +23 lines, -34 lines 0 comments Download
M device/devices_app/usb/type_converters.h View 2 chunks +2 lines, -10 lines 0 comments Download
M device/devices_app/usb/type_converters.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M device/usb/mock_usb_device_handle.h View 3 chunks +11 lines, -14 lines 0 comments Download
M device/usb/usb_device_handle.h View 3 chunks +9 lines, -23 lines 0 comments Download
M device/usb/usb_device_handle_impl.h View 2 chunks +14 lines, -23 lines 0 comments Download
M device/usb/usb_device_handle_impl.cc View 14 chunks +90 lines, -166 lines 0 comments Download
M extensions/browser/api/usb/usb_api.h View 3 chunks +2 lines, -6 lines 0 comments Download
M extensions/browser/api/usb/usb_api.cc View 4 chunks +29 lines, -74 lines 0 comments Download
M extensions/browser/api/usb/usb_apitest.cc View 4 chunks +5 lines, -46 lines 0 comments Download
M extensions/test/data/api_test/usb/transfer_event/test.js View 4 chunks +0 lines, -4 lines 0 comments Download
M extensions/test/data/api_test/usb/transfer_failure/test.js View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhaoqin1
Created Revert of Update device/usb and its Mojo interface for variable size ISO packets.
4 years, 10 months ago (2016-02-02 17:22:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1658953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1658953003/1
4 years, 10 months ago (2016-02-02 17:23:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-02 17:25:59 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c40c36ef3d3a722e0df920a4bbae25695f0b18e8 Cr-Commit-Position: refs/heads/master@{#372971}
4 years, 10 months ago (2016-02-02 17:27:43 UTC) #6
Reilly Grant (use Gerrit)
4 years, 10 months ago (2016-02-02 21:12:21 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1665453002/ by reillyg@chromium.org.

The reason for reverting is: Fixed the uninitialized test buffer..

Powered by Google App Engine
This is Rietveld 408576698