Subzero: Cleanup Inst==>Instr.

Subzero: Cleanup Inst==>Instr.

In the beginning, Ice::Inst was called IceInst, and patterns like "IceInst *Inst = ..." made perfect sense.

After the Ice:: name change, "Inst *Inst = ..." continued to compile, mostly.

However, shadowing a type name is clumsy and newer code tends to use "Inst *Instr", so we might as well switch all the instances over.

Some are still called "I" and those are left alone.

BUG= none
R=kschimpf@google.com

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=8cfeb69e17190d3bfe22a8a1cbd7679a114d68cf

[Jim Stichnoth, 2016-02-05 00:22:43]

Description was changed from

==========
Subzero: Cleanup Inst==>Instr.

BUG= none
==========

to

==========
Subzero: Cleanup Inst==>Instr.

In the beginning, Ice::Inst was called IceInst, and patterns like "IceInst *Inst
= ..." made perfect sense.

After the Ice:: name change, "Inst *Inst = ..." continued to compile, mostly.

However, shadowing a type name is clumsy and newer code tends to use "Inst
*Instr", so we might as well switch all the instances over.

Some are still called "I" and those are left alone.

BUG= none
==========

[Jim Stichnoth, 2016-02-05 00:22:43]

stichnot@chromium.org changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, kschimpf@google.com, sehr@chromium.org

[Karl, 2016-02-05 15:21:27]

lgtm

[Jim Stichnoth, 2016-02-05 17:50:06]

Description was changed from

==========
Subzero: Cleanup Inst==>Instr.

In the beginning, Ice::Inst was called IceInst, and patterns like "IceInst *Inst
= ..." made perfect sense.

After the Ice:: name change, "Inst *Inst = ..." continued to compile, mostly.

However, shadowing a type name is clumsy and newer code tends to use "Inst
*Instr", so we might as well switch all the instances over.

Some are still called "I" and those are left alone.

BUG= none
==========

to

==========
Subzero: Cleanup Inst==>Instr.

In the beginning, Ice::Inst was called IceInst, and patterns like "IceInst *Inst
= ..." made perfect sense.

After the Ice:: name change, "Inst *Inst = ..." continued to compile, mostly.

However, shadowing a type name is clumsy and newer code tends to use "Inst
*Instr", so we might as well switch all the instances over.

Some are still called "I" and those are left alone.

BUG= none
R=kschimpf@google.com

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-02-05 17:50:07]

Committed patchset #1 (id:1) manually as
8cfeb69e17190d3bfe22a8a1cbd7679a114d68cf (presubmit successful).