Don't propagate bbox for empty <text> to ancestors

Don't propagate bbox for empty <text> to ancestors

If we have a <text> element which is "empty" (essentially has no text
content after collapsing spaces), then its bounding box would be empty,
but would still be propagated to the bounding boxes of the ancestors -
which could span them out to be bigger than expected. Similarly they
could be subject to their userspace transform with a similar effect.

Skip propagation of empty <text> element - where "empty" is defined as
"has no line boxes".

BUG=450229
Committed: https://crrev.com/9960fef706fbd5429e65360e3ebeecce63c8c8f0
Cr-Commit-Position: refs/heads/master@{#373501}

[fs, 2016-02-03 17:50:20]

fs@opera.com changed reviewers:
+ pdr@chromium.org

[Stephen Chennney, 2016-02-03 19:10:27]

schenney@chromium.org changed reviewers:
+ schenney@chromium.org

[Stephen Chennney, 2016-02-03 19:10:28]

lgtm for this situation.

A similar issue came up years back, and I wanted to add code that treated 0-size
rectangles as empty for bounds, regardless of the location, but we never went
through with it. Was before the WebKit fork, I think.

[fs, 2016-02-03 21:16:08]

On 2016/02/03 at 19:10:28, schenney wrote:
> lgtm for this situation.
> 
> A similar issue came up years back, and I wanted to add code that treated
0-size rectangles as empty for bounds, regardless of the location, but we never
went through with it. Was before the WebKit fork, I think.

There was a mention in the bug about "positioned zero-sized" bboxes. That
definitely a different issue though - and not necessarily one we want to pursue
since it seems the behavior we get with this CL is at least interoperable with
Gecko.

[fs, 2016-02-04 09:31:43]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-02-04 09:33:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1661983002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1661983002/1

[commit-bot: I haz the power, 2016-02-04 10:48:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-04 10:49:46]

Description was changed from

==========
Don't propagate bbox for empty <text> to ancestors

If we have a <text> element which is "empty" (essentially has no text
content after collapsing spaces), then its bounding box would be empty,
but would still be propagated to the bounding boxes of the ancestors -
which could span them out to be bigger than expected. Similarly they
could be subject to their userspace transform with a similar effect.

Skip propagation of empty <text> element - where "empty" is defined as
"has no line boxes".

BUG=450229
==========

to

==========
Don't propagate bbox for empty <text> to ancestors

If we have a <text> element which is "empty" (essentially has no text
content after collapsing spaces), then its bounding box would be empty,
but would still be propagated to the bounding boxes of the ancestors -
which could span them out to be bigger than expected. Similarly they
could be subject to their userspace transform with a similar effect.

Skip propagation of empty <text> element - where "empty" is defined as
"has no line boxes".

BUG=450229

Committed: https://crrev.com/9960fef706fbd5429e65360e3ebeecce63c8c8f0
Cr-Commit-Position: refs/heads/master@{#373501}
==========

[commit-bot: I haz the power, 2016-02-04 10:49:47]

Patchset 1 (id:??) landed as
https://crrev.com/9960fef706fbd5429e65360e3ebeecce63c8c8f0
Cr-Commit-Position: refs/heads/master@{#373501}