third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp - Issue 1661983002: Don't propagate bbox for empty <text> to ancestors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp

Issue 1661983002: Don't propagate bbox for empty <text> to ancestors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp

index 49ca3a8d5be6e9f122b066b1aecb50906453c36f..973ba5d3794a2901cd410db73dfbda1a5371133a 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp

@@ -497,6 +497,12 @@ FloatRect LayoutSVGText::paintInvalidationRectInLocalCoordinates() const

return paintInvalidationRect;

}

+bool LayoutSVGText::isObjectBoundingBoxValid() const

+ // If we don't have any line boxes, then consider the bbox invalid.

+ return firstLineBox();

void LayoutSVGText::addChild(LayoutObject* child, LayoutObject* beforeChild)

{

LayoutSVGBlock::addChild(child, beforeChild);