Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Side by Side Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGText.h

Issue 1661983002: Don't propagate bbox for empty <text> to ancestors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Apple Computer, Inc. 2 * Copyright (C) 2006 Apple Computer, Inc.
3 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org> 3 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org>
4 * Copyright (C) Research In Motion Limited 2010-2012. All rights reserved. 4 * Copyright (C) Research In Motion Limited 2010-2012. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 26 matching lines...) Expand all
37 ~LayoutSVGText() override; 37 ~LayoutSVGText() override;
38 38
39 bool isChildAllowed(LayoutObject*, const ComputedStyle&) const override; 39 bool isChildAllowed(LayoutObject*, const ComputedStyle&) const override;
40 40
41 void setNeedsPositioningValuesUpdate() { m_needsPositioningValuesUpdate = tr ue; } 41 void setNeedsPositioningValuesUpdate() { m_needsPositioningValuesUpdate = tr ue; }
42 void setNeedsTransformUpdate() override { m_needsTransformUpdate = true; } 42 void setNeedsTransformUpdate() override { m_needsTransformUpdate = true; }
43 void setNeedsTextMetricsUpdate() { m_needsTextMetricsUpdate = true; } 43 void setNeedsTextMetricsUpdate() { m_needsTextMetricsUpdate = true; }
44 FloatRect paintInvalidationRectInLocalCoordinates() const override; 44 FloatRect paintInvalidationRectInLocalCoordinates() const override;
45 FloatRect objectBoundingBox() const override { return FloatRect(frameRect()) ; } 45 FloatRect objectBoundingBox() const override { return FloatRect(frameRect()) ; }
46 FloatRect strokeBoundingBox() const override; 46 FloatRect strokeBoundingBox() const override;
47 bool isObjectBoundingBoxValid() const;
47 48
48 static LayoutSVGText* locateLayoutSVGTextAncestor(LayoutObject*); 49 static LayoutSVGText* locateLayoutSVGTextAncestor(LayoutObject*);
49 static const LayoutSVGText* locateLayoutSVGTextAncestor(const LayoutObject*) ; 50 static const LayoutSVGText* locateLayoutSVGTextAncestor(const LayoutObject*) ;
50 51
51 bool needsReordering() const { return m_needsReordering; } 52 bool needsReordering() const { return m_needsReordering; }
52 Vector<SVGTextLayoutAttributes*>& layoutAttributes() { return m_layoutAttrib utes; } 53 Vector<SVGTextLayoutAttributes*>& layoutAttributes() { return m_layoutAttrib utes; }
53 54
54 void subtreeChildWasAdded(LayoutObject*); 55 void subtreeChildWasAdded(LayoutObject*);
55 void subtreeChildWillBeRemoved(LayoutObject*, Vector<SVGTextLayoutAttributes *, 2>& affectedAttributes); 56 void subtreeChildWillBeRemoved(LayoutObject*, Vector<SVGTextLayoutAttributes *, 2>& affectedAttributes);
56 void subtreeChildWasRemoved(const Vector<SVGTextLayoutAttributes*, 2>& affec tedAttributes); 57 void subtreeChildWasRemoved(const Vector<SVGTextLayoutAttributes*, 2>& affec tedAttributes);
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 bool m_needsTextMetricsUpdate : 1; 89 bool m_needsTextMetricsUpdate : 1;
89 SVGTextLayoutAttributesBuilder m_layoutAttributesBuilder; 90 SVGTextLayoutAttributesBuilder m_layoutAttributesBuilder;
90 Vector<SVGTextLayoutAttributes*> m_layoutAttributes; 91 Vector<SVGTextLayoutAttributes*> m_layoutAttributes;
91 }; 92 };
92 93
93 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutSVGText, isSVGText()); 94 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutSVGText, isSVGText());
94 95
95 } // namespace blink 96 } // namespace blink
96 97
97 #endif 98 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698