third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp - Issue 1661983002: Don't propagate bbox for empty <text> to ancestors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp

Issue 1661983002: Don't propagate bbox for empty <text> to ancestors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp b/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp

index 59ea565b1101fbca4451f940cda413a70e1f2c12..a1ad16265753f22fc8eeedc0e241021f4cdd1259 100644

--- a/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp

@@ -196,6 +196,9 @@ void SVGLayoutSupport::computeContainerBoundingBoxes(const LayoutObject* contain

if (current->isSVGShape() && toLayoutSVGShape(current)->isShapeEmpty())

continue;

+ if (current->isSVGText() && !toLayoutSVGText(current)->isObjectBoundingBoxValid())

+ continue;

const AffineTransform& transform = current->localToParentTransform();

updateObjectBoundingBox(objectBoundingBox, objectBoundingBoxValid, current,

transform.mapRect(current->objectBoundingBox()));

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp ('k') | no next file » | no next file with comments »